Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in libkvm on FreeBSD #90495

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Pull in libkvm on FreeBSD #90495

merged 1 commit into from
Nov 2, 2021

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Nov 2, 2021

This is needed when updating libc after rust-lang/libc#2451.

Spotted in #90464 where it caused rust-analyzer to fail to link.

Similar to #88676.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Nov 2, 2021

📌 Commit ee3b466 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2021
@bors
Copy link
Contributor

bors commented Nov 2, 2021

⌛ Testing commit ee3b466 with merge 18bc4be...

@bors
Copy link
Contributor

bors commented Nov 2, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 18bc4be to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 2, 2021
@bors bors merged commit 18bc4be into rust-lang:master Nov 2, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 2, 2021
@lnicola lnicola deleted the freebsd-kvm branch November 2, 2021 18:30
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (18bc4be): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 15, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 16, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 16, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 16, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants