Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erase regions within vtable_trait_first_method_offset #90536

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Nov 3, 2021

Fixes #90177 .

r? @jackh726

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2021
@rust-log-analyzer

This comment has been minimized.

src/test/ui/traits/vtable/vtable-hrtb.rs Outdated Show resolved Hide resolved
@jackh726
Copy link
Member

jackh726 commented Nov 3, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 3, 2021
@bors
Copy link
Contributor

bors commented Nov 3, 2021

⌛ Trying commit 8841204 with merge f155cf50ec3c87dad1e65b3a9a1a9203b159f7bc...

@bors
Copy link
Contributor

bors commented Nov 3, 2021

☀️ Try build successful - checks-actions
Build commit: f155cf50ec3c87dad1e65b3a9a1a9203b159f7bc (f155cf50ec3c87dad1e65b3a9a1a9203b159f7bc)

@rust-timer
Copy link
Collaborator

Queued f155cf50ec3c87dad1e65b3a9a1a9203b159f7bc with parent 473eaa4, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f155cf50ec3c87dad1e65b3a9a1a9203b159f7bc): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 3, 2021
@crlf0710 crlf0710 requested a review from jackh726 November 4, 2021 16:44
@jackh726
Copy link
Member

jackh726 commented Nov 4, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Nov 4, 2021

📌 Commit 8841204 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2021
@bors
Copy link
Contributor

bors commented Nov 4, 2021

⌛ Testing commit 8841204 with merge 2cff30b...

@bors
Copy link
Contributor

bors commented Nov 5, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 2cff30b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 5, 2021
@bors bors merged commit 2cff30b into rust-lang:master Nov 5, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 5, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2cff30b): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE with trait objects and HRTBs
7 participants