-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-export some iterators from core
in std
#90604
Conversation
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@@ -46,7 +46,7 @@ pub use core::str::pattern; | |||
pub use core::str::EncodeUtf16; | |||
#[stable(feature = "split_ascii_whitespace", since = "1.34.0")] | |||
pub use core::str::SplitAsciiWhitespace; | |||
#[stable(feature = "split_inclusive", since = "1.53.0")] | |||
#[stable(feature = "split_inclusive", since = "1.51.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually incorrect. It hadn't been picked up, since it was across crates.
@bors r+ rollup |
📌 Commit ed63c71 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d22dd65): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
These iterators seem to have been forgotten to be re-exported from
std
(throughalloc
)These are stable:
core::slice::{SplitInclusive, SplitInclusiveMut}
This one is still unstable:
core::slice::EscapeAscii
(cc #77174)