Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more clippy fixes #90668

Merged
merged 1 commit into from
Nov 7, 2021
Merged

more clippy fixes #90668

merged 1 commit into from
Nov 7, 2021

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2021
@jyn514
Copy link
Member

jyn514 commented Nov 7, 2021

@bors try @rust-timer queue

r=me assuming perf isn't too bad :)

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 7, 2021
@bors
Copy link
Contributor

bors commented Nov 7, 2021

⌛ Trying commit 5f58acf7cc6c20f022c63b3917839954d81b7edd with merge a8cc143f16a2f039e5635ec664795b3954ac98df...

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 7, 2021
@bors
Copy link
Contributor

bors commented Nov 7, 2021

☀️ Try build successful - checks-actions
Build commit: a8cc143f16a2f039e5635ec664795b3954ac98df (a8cc143f16a2f039e5635ec664795b3954ac98df)

@rust-timer
Copy link
Collaborator

Queued a8cc143f16a2f039e5635ec664795b3954ac98df with parent 90a273b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a8cc143f16a2f039e5635ec664795b3954ac98df): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 7, 2021
@matthiaskrgr
Copy link
Member Author

removed the autoderef var.

@bors r=jyn514

@bors
Copy link
Contributor

bors commented Nov 7, 2021

📌 Commit 5c45455 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2021
@bors
Copy link
Contributor

bors commented Nov 7, 2021

⌛ Testing commit 5c45455 with merge d519729aacaf4e34857f73222a0227ac97b53626...

@bors
Copy link
Contributor

bors commented Nov 7, 2021

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2021
@jyn514
Copy link
Member

jyn514 commented Nov 7, 2021

GitHub Actions has encountered an internal error when running your job.

🤦

@bors retry

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2021
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 7, 2021
@bors
Copy link
Contributor

bors commented Nov 7, 2021

⌛ Testing commit 5c45455 with merge 46b8e74...

@bors
Copy link
Contributor

bors commented Nov 7, 2021

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 46b8e74 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2021
@bors bors merged commit 46b8e74 into rust-lang:master Nov 7, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 7, 2021
@bors bors mentioned this pull request Nov 7, 2021
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (46b8e74): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jackh726 jackh726

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
8 participants
@matthiaskrgr @rust-highfive @jyn514 @rust-timer @bors @rust-log-analyzer @jackh726 @rustbot