rustdoc: Finish transition to computed visibility #90844

camelid · 2021-11-12T21:52:39Z

This finishes the transition to using computed visibility in rustdoc.

rust-highfive · 2021-11-12T21:52:42Z

r? @CraftSpider

(rust-highfive has picked a reviewer for you, use r? to override)

camelid · 2021-11-12T21:59:27Z

cc #88447 @inquisitivecrystal @jyn514

Is there a reason the places I've updated can't use computed visibility, or should it be okay to change?

inquisitivecrystal · 2021-11-12T22:10:19Z

cc #88447 @inquisitivecrystal @jyn514

Is there a reason the places I've updated can't use computed visibility, or should it be okay to change?

None that I'm aware of. It looks like I just missed these. I wasn't aware of the item.vis.clean() notation, which is probably why I didn't catch these instances. I'm sorry you had to go to the trouble.

In any case, while other people are in a better position to confirm that the alternations make sense in context, they look good to me.

src/librustdoc/clean/mod.rs

camelid · 2021-11-12T22:33:29Z

I wasn't aware of the item.vis.clean() notation, which is probably why I didn't catch these instances.

I've been trying to reduce the usage of Clean since it's confusing and easy to not notice. It's confusing even for rustdoc team members.

I'm sorry you had to go to the trouble.

It's no trouble at all; thanks for starting the process in that PR :)

camelid · 2021-11-12T22:34:01Z

Looks like a test is failing in CI...

camelid · 2021-11-13T05:12:55Z

Marking as draft since I'll want to squash my commits / edit commit messages after you review.

src/librustdoc/clean/mod.rs

jyn514 · 2021-11-13T13:03:23Z

@bors try @rust-timer queue

rust-timer · 2021-11-13T13:03:24Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-11-13T13:03:30Z

⌛ Trying commit 9793f5fcae6fc2908c0e69b079ec002b1eef92ea with merge d477b91dd0b64ecd708232320626f4ee548ee264...

bors · 2021-11-13T14:43:21Z

☀️ Try build successful - checks-actions
Build commit: d477b91dd0b64ecd708232320626f4ee548ee264 (d477b91dd0b64ecd708232320626f4ee548ee264)

rust-timer · 2021-11-13T14:43:23Z

Queued d477b91dd0b64ecd708232320626f4ee548ee264 with parent 3e018ce, future comparison URL.

rust-timer · 2021-11-13T16:14:59Z

Finished benchmarking commit (d477b91dd0b64ecd708232320626f4ee548ee264): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

Very large improvement in instruction counts (up to -5.0% on incr-unchanged builds of inflate)
Large regression in instruction counts (up to 3.9% on incr-unchanged builds of deep-vector)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

jyn514 · 2021-11-17T15:48:19Z

Marking as draft since I'll want to squash my commits / edit commit messages after you review.

Oh oops - feel free to r=me whenever you're ready.

@bors r-

This change should make the code a bit clearer and easier to change.

This should be the last bit of the transition to computed visibility, rather than syntactic visibility.

* Remove outdated comment * Remove duplicated code * Extract helper function

camelid · 2021-11-17T15:54:47Z

@bors r=jyn514 rollup=maybe

bors · 2021-11-17T15:54:48Z

📌 Commit 64d6997 has been approved by jyn514

camelid · 2021-11-17T15:55:23Z

Eh, there's slight rustdoc perf improvements, so I'll use iffy @bors rollup=iffy

camelid · 2021-11-17T16:51:37Z

(Pretty sure CI failure is spurious, so not unapproving.)

bors · 2021-11-21T06:12:39Z

⌛ Testing commit 64d6997 with merge 2b6918c43c1c70f857c3b543f2ba1e84e891b66b...

rust-log-analyzer · 2021-11-21T07:15:08Z

The job x86_64-msvc-cargo failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test workspaces::ws_warn_unused ... ok

failures:

---- lto::complicated stdout ----
running `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe build -v --release`
thread 'lto::complicated' panicked at '
test failed running `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe build -v --release`
error: process exited with code 101 (expected 0)

--- stderr
--- stderr
    Updating `dummy-registry` index
---
The targets should have unique names.
Consider changing their names to be unique or compiling them separately.
This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.
   Compiling dep-shared v0.0.1
   Compiling dep-build2 v0.0.1
   Compiling dep-normal2 v0.0.1
   Compiling dep-proc-macro2 v0.0.1
     Running `rustc --crate-name dep_shared D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\home\.cargo\registry\src\-5df8a1ccca24ba7a\dep-shared-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C metadata=815663fa4ca118de -C extra-filename=-815663fa4ca118de --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --cap-lints allow`
     Running `rustc --crate-name dep_build2 D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\home\.cargo\registry\src\-5df8a1ccca24ba7a\dep-build2-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C metadata=df572682f4638748 -C extra-filename=-df572682f4638748 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --cap-lints allow`
     Running `rustc --crate-name dep_normal2 D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\home\.cargo\registry\src\-5df8a1ccca24ba7a\dep-normal2-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C linker-plugin-lto -C metadata=8cf56e81cc7e8007 -C extra-filename=-8cf56e81cc7e8007 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --cap-lints allow`
     Running `rustc --crate-name dep_proc_macro2 D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\home\.cargo\registry\src\-5df8a1ccca24ba7a\dep-proc-macro2-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C metadata=f829152b9eb79c53 -C extra-filename=-f829152b9eb79c53 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --cap-lints allow`
   Compiling dep-normal v0.0.1
     Running `rustc --crate-name dep_normal D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\home\.cargo\registry\src\-5df8a1ccca24ba7a\dep-normal-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C linker-plugin-lto -C metadata=06ea447f8e785b1a -C extra-filename=-06ea447f8e785b1a --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --extern dep_normal2=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\libdep_normal2-8cf56e81cc7e8007.rmeta --extern dep_shared=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\libdep_shared-815663fa4ca118de.rmeta --cap-lints allow`
   Compiling dep-build v0.0.1
     Running `rustc --crate-name dep_build D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\home\.cargo\registry\src\-5df8a1ccca24ba7a\dep-build-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C metadata=4b7343fd1f9e1e57 -C extra-filename=-4b7343fd1f9e1e57 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --extern dep_build2=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\libdep_build2-df572682f4638748.rmeta --extern dep_shared=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\libdep_shared-815663fa4ca118de.rmeta --cap-lints allow`
   Compiling dep-proc-macro v0.0.1
     Running `rustc --crate-name dep_proc_macro D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\home\.cargo\registry\src\-5df8a1ccca24ba7a\dep-proc-macro-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C opt-level=3 -C embed-bitcode=no -C metadata=92b443923583e648 -C extra-filename=-92b443923583e648 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --extern dep_proc_macro2=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\libdep_proc_macro2-f829152b9eb79c53.rlib --extern dep_shared=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\libdep_shared-815663fa4ca118de.rlib --extern proc_macro --cap-lints allow`
   Compiling test v0.0.0 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo)
     Running `rustc --crate-name build_script_build build.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type bin --emit=dep-info,link -C opt-level=3 -C embed-bitcode=no -C metadata=1132ccd72abf6ae6 -C extra-filename=-1132ccd72abf6ae6 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\build\test-1132ccd72abf6ae6 -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --extern dep_build=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\libdep_build-4b7343fd1f9e1e57.rlib`
     Running `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\build\test-1132ccd72abf6ae6\build-script-build`
     Running `rustc --crate-name test src\main.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type bin --emit=dep-info,link -C opt-level=3 -C lto -C metadata=f9bd7972e02c2e3b --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --extern dep_normal=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\libdep_normal-06ea447f8e785b1a.rlib --extern dep_proc_macro=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\dep_proc_macro-92b443923583e648.dll`
     Running `rustc --crate-name test src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type cdylib --crate-type staticlib --emit=dep-info,link -C opt-level=3 -C lto -C metadata=10d13534f609fec7 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --extern dep_normal=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\libdep_normal-06ea447f8e785b1a.rlib --extern dep_proc_macro=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\dep_proc_macro-92b443923583e648.dll`
error: linking with `link.exe` failed: exit code: 1201
  |
  = note: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x64\\link.exe" "/DEF:C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcavVwCS\\lib.def" "/NOLOGO" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\tmp\\cit\\t1298\\foo\\target\\release\\deps\\test.test.3b04ecf7-cgu.0.rcgu.o" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\tmp\\cit\\t1298\\foo\\target\\release\\deps" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-2e46b64d42824fd5.rlib" "kernel32.lib" "ws2_32.lib" "bcrypt.lib" "advapi32.lib" "userenv.lib" "kernel32.lib" "msvcrt.lib" "/NXCOMPAT" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "/OUT:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\tmp\\cit\\t1298\\foo\\target\\release\\deps\\test.dll" "/OPT:REF,ICF" "/DLL" "/IMPLIB:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\tmp\\cit\\t1298\\foo\\target\\release\\deps\\test.dll.lib" "/DEBUG"
  = note: LINK : fatal error LNK1201: error writing to program database 'D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\test.pdb'; check for insufficient disk space, invalid path, or insufficient privilege

error: could not compile `test` due to previous error

Caused by:
Caused by:
  process didn't exit successfully: `rustc --crate-name test src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type cdylib --crate-type staticlib --emit=dep-info,link -C opt-level=3 -C lto -C metadata=10d13534f609fec7 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps --extern dep_normal=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\libdep_normal-06ea447f8e785b1a.rlib --extern dep_proc_macro=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1298\foo\target\release\deps\dep_proc_macro-92b443923583e648.dll` (exit code: 1)
error: build failed
', src\tools\cargo\tests\testsuite\lto.rs:217:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

bors · 2021-11-21T07:15:27Z

💔 Test failed - checks-actions

jyn514 · 2021-11-21T08:32:12Z

@bors retry

bors · 2021-11-21T13:26:34Z

⌛ Testing commit 64d6997 with merge 49d4232...

bors · 2021-11-21T16:36:48Z

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 49d4232 to master...

rust-timer · 2021-11-21T18:07:18Z

Finished benchmarking commit (49d4232): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

camelid added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 12, 2021

rust-highfive assigned CraftSpider Nov 12, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2021

This comment has been minimized.

Sign in to view

jyn514 reviewed Nov 12, 2021

View reviewed changes

src/librustdoc/clean/mod.rs Show resolved Hide resolved

camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2021

camelid assigned jyn514 and unassigned CraftSpider Nov 13, 2021

camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2021

camelid marked this pull request as draft November 13, 2021 05:12

camelid commented Nov 13, 2021

View reviewed changes

src/librustdoc/clean/mod.rs Show resolved Hide resolved

jyn514 reviewed Nov 13, 2021

View reviewed changes

src/librustdoc/clean/mod.rs Outdated Show resolved Hide resolved

src/librustdoc/clean/mod.rs Show resolved Hide resolved

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 13, 2021

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 13, 2021

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 17, 2021

camelid added 3 commits November 17, 2021 10:52

rustdoc: Clean Visibility outside of display_macro_source

7a7698a

This change should make the code a bit clearer and easier to change.

rustdoc: Remove Clean impl for hir::Visibility

94ae60a

This should be the last bit of the transition to computed visibility, rather than syntactic visibility.

rustdoc: Cleanup visibility cleaning some more

64d6997

* Remove outdated comment * Remove duplicated code * Extract helper function

camelid force-pushed the cleanup-vis branch from 0aec4a4 to 64d6997 Compare November 17, 2021 15:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 21, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 21, 2021

bors merged commit 49d4232 into rust-lang:master Nov 21, 2021

rustbot added this to the 1.58.0 milestone Nov 21, 2021

rustbot removed the perf-regression Performance regression. label Nov 21, 2021

camelid deleted the cleanup-vis branch November 21, 2021 19:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustdoc: Finish transition to computed visibility #90844

rustdoc: Finish transition to computed visibility #90844

camelid commented Nov 12, 2021

rust-highfive commented Nov 12, 2021

camelid commented Nov 12, 2021

inquisitivecrystal commented Nov 12, 2021

This comment has been minimized.

camelid commented Nov 12, 2021

camelid commented Nov 12, 2021

camelid commented Nov 13, 2021 •

edited

Loading

jyn514 commented Nov 13, 2021

rust-timer commented Nov 13, 2021

bors commented Nov 13, 2021

bors commented Nov 13, 2021

rust-timer commented Nov 13, 2021

rust-timer commented Nov 13, 2021

jyn514 commented Nov 17, 2021

camelid commented Nov 17, 2021

bors commented Nov 17, 2021

camelid commented Nov 17, 2021

camelid commented Nov 17, 2021

bors commented Nov 21, 2021

rust-log-analyzer commented Nov 21, 2021

bors commented Nov 21, 2021

jyn514 commented Nov 21, 2021

bors commented Nov 21, 2021

bors commented Nov 21, 2021

rust-timer commented Nov 21, 2021

rustdoc: Finish transition to computed visibility #90844

rustdoc: Finish transition to computed visibility #90844

Conversation

camelid commented Nov 12, 2021

rust-highfive commented Nov 12, 2021

camelid commented Nov 12, 2021

inquisitivecrystal commented Nov 12, 2021

This comment has been minimized.

camelid commented Nov 12, 2021

camelid commented Nov 12, 2021

camelid commented Nov 13, 2021 • edited Loading

jyn514 commented Nov 13, 2021

rust-timer commented Nov 13, 2021

bors commented Nov 13, 2021

bors commented Nov 13, 2021

rust-timer commented Nov 13, 2021

rust-timer commented Nov 13, 2021

jyn514 commented Nov 17, 2021

camelid commented Nov 17, 2021

bors commented Nov 17, 2021

camelid commented Nov 17, 2021

camelid commented Nov 17, 2021

bors commented Nov 21, 2021

rust-log-analyzer commented Nov 21, 2021

bors commented Nov 21, 2021

jyn514 commented Nov 21, 2021

bors commented Nov 21, 2021

bors commented Nov 21, 2021

rust-timer commented Nov 21, 2021

camelid commented Nov 13, 2021 •

edited

Loading