Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to decode utf-8 while handling errors #90980

Closed
wants to merge 4 commits into from

Conversation

mbartlett21
Copy link
Contributor

Tracking issue: TODO

@rust-highfive
Copy link
Collaborator

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2021
@mbartlett21 mbartlett21 mentioned this pull request Nov 17, 2021
3 tasks
@mbartlett21
Copy link
Contributor Author

Actually, after looking around a bit, Rust already had this and it was deprecated and removed, so closing for now.

(#33906)

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
skip untracked path src/doc/rust-by-example/ during rustfmt invocations
skip untracked path src/llvm-project/ during rustfmt invocations
Diff in /checkout/library/core/src/char/decode.rs at line 74:
 #[inline]
 #[unstable(feature = "decode_utf8", issue = "none")]
 pub fn decode_utf8<I: IntoIterator<Item = u8>>(iter: I) -> DecodeUtf8<I::IntoIter> {
-    DecodeUtf8 {
-        iter: iter.into_iter(),
-        buf: DecodeUtf8Buffer::Empty,
-    }
+    DecodeUtf8 { iter: iter.into_iter(), buf: DecodeUtf8Buffer::Empty }
 
 #[derive(Clone, Debug)]
 #[derive(Clone, Debug)]
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/library/core/src/char/decode.rs" "/checkout/library/core/src/prelude/v1.rs" "/checkout/library/core/src/char/mod.rs" "/checkout/library/core/src/lib.rs" "/checkout/library/core/src/stream/mod.rs" "/checkout/library/core/src/iter/range.rs" "/checkout/library/core/src/iter/sources/from_fn.rs" "/checkout/library/core/src/prelude/mod.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.

@mbartlett21 mbartlett21 deleted the decode-utf8 branch May 30, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants