Add a caveat to std::os::windows::fs::symlink_file #91049
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
This looks reasonable to me and should probably be added to I do have one quibble on the advice about developer mode, etc. I'm not sure if this should be in the Rust docs because such things are subject to change outside of Rust. For example, using symlinks in developer mode was introduced in Windows 10 1703 and it's possible this could be changed again in the future (e.g. a separate toggle or by making it the default). |
This is similar to the note on [Python's `os.symlink()`](https://docs.python.org/3/library/os.html#os.symlink). Some additional notes in dimo414/bkt#3.
|
Thanks, I've mirrored the text to I definitely appreciate not wanting to tightly-couple these docs to Windows' behavior, but this failure mode is really confusing and surprising so I think these are helpful breadcrumbs. I attempted to make it clear these are just suggestions ("Users can try") and not necessarily what will work or what should be done. Open to wordsmithing though :) |
apiraino
added
the
T-libs
|
@bors r+ rollup |
|
📌 Commit 9c3b0d8 has been approved by |
bors
added
S-waiting-on-bors
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#91049 (Add a caveat to std::os::windows::fs::symlink_file) - rust-lang#91281 (Add demonstration test for rust-lang#91161) - rust-lang#91327 (Delete an unreachable codepath from format_args implementation) - rust-lang#91336 (Remove unused root_parent.) - rust-lang#91349 (Accumulate all values of `-C remark` option) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This is similar to the note on Python's
os.symlink(). Some additional notes in dimo414/bkt#3.