Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TryFrom<&'_ mut [T]> for [T; N] #91086

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Implement TryFrom<&'_ mut [T]> for [T; N] #91086

merged 4 commits into from
Dec 13, 2021

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Nov 20, 2021

Fixes #91085.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rhysd rhysd force-pushed the issue-91085 branch 2 times, most recently from 9afb451 to b50245c Compare November 20, 2021 13:05
@rhysd rhysd marked this pull request as ready for review November 20, 2021 14:17
@rhysd
Copy link
Contributor Author

rhysd commented Nov 20, 2021

I confirmed ./x.py test ./library/core passed on my machine (macOS 11.6.1).

jyn514
jyn514 suggested changes Nov 20, 2021
View reviewed changes
library/core/src/array/mod.rs Outdated Show resolved Hide resolved
@jyn514 jyn514 added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 20, 2021
@rhysd @jyn514
Update version in stable attribute
66e0523 
Co-authored-by: Joshua Nelson <github@jyn.dev>
@Mark-Simulacrum
Copy link
Member

r? rust-lang/libs-api for the fcp

@dtolnay
Copy link
Member

dtolnay commented Nov 21, 2021

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Nov 21, 2021 •
edited by m-ou-se
Loading

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Nov 21, 2021
@rhysd @camelid
Reborrow mut slice instead of converting it with as_ref
ac083c6 
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
@inquisitivecrystal inquisitivecrystal added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 21, 2021
@rhysd
Copy link
Contributor Author

rhysd commented Dec 2, 2021

@jyn514 Would you review this PR again? I applied all suggestions and I believe it's ready for merge.

@jyn514
Copy link
Member

jyn514 commented Dec 2, 2021

@rhysd it needs to wait for the FCP to finish first (so at least one more T-libs member needs to approve, and them the final comment period lasts 10 days).

@rhysd
Copy link
Contributor Author

rhysd commented Dec 2, 2021

@jyn514 I got it. I misunderstood that the approval needs to be done before finishing FCP.

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Dec 2, 2021
@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Dec 2, 2021
@rfcbot
Copy link

rfcbot commented Dec 2, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 12, 2021
@rfcbot
Copy link

rfcbot commented Dec 12, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@m-ou-se
Copy link
Member

m-ou-se commented Dec 12, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Dec 12, 2021

📌 Commit 16711fe has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 12, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2021
@bors
Auto merge of rust-lang#91841 - matthiaskrgr:rollup-zlhsg5a, r=matthi…
f7fd79a 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#91086 (Implement `TryFrom<&'_ mut [T]>` for `[T; N]`)
 - rust-lang#91091 (Stabilize `ControlFlow::{is_break, is_continue}`)
 - rust-lang#91749 (BTree: improve public descriptions and comments)
 - rust-lang#91819 (rustbot: Add autolabeling for `T-compiler`)
 - rust-lang#91824 (Make `(*mut T)::write_bytes` `const`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 42f8d48 into rust-lang:master Dec 13, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 13, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

@camelid camelid camelid left review comments

@jyn514 jyn514 jyn514 requested changes

Assignees

@dtolnay dtolnay

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

&[T] can be converted into [T; N] but &mut [T] can't