-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store hir_id_to_def_id in OwnerNodes. #91112
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit a8771c6800377125b7fc5df00b60563bb529c198 with merge beaf918adcf84a91683827db6b76fd8f00681595... |
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions |
Queued beaf918adcf84a91683827db6b76fd8f00681595 with parent 49d4232, future comparison URL. |
Finished benchmarking commit (beaf918adcf84a91683827db6b76fd8f00681595): comparison url. Summary: This change led to large relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 1d9023ef83a39165a1d255517bf75025599b2730 with merge 89f519c544b7437eda1f1deb79c9784bc4b60f1a... |
☀️ Try build successful - checks-actions |
Queued 89f519c544b7437eda1f1deb79c9784bc4b60f1a with parent cafc458, future comparison URL. |
Finished benchmarking commit (89f519c544b7437eda1f1deb79c9784bc4b60f1a): comparison url. Summary: This change led to large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
2602bee
to
74c377a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #93301) made this pull request unmergeable. Please resolve the merge conflicts. |
Replaced by #93301. |
Half step in #89278.
The
HirId -> LocalDefId
is currently untracked by incr. comp.Although it has not been identified as causing incr. comp. bugs, there is no insurance against such future bugs.
This PR aims to restructure those maps consistently with the HIR itself.