Code

Rollup of 7 pull requests#91157

Code

Closed

matthiaskrgr wants to merge 171 commits intorust-lang:masterrust-lang/rust:masterfrom matthiaskrgr:rollup-uj56mdmmatthiaskrgr/rust:rollup-uj56mdmCopy head branch name to clipboard

+6,655-2,600

Commits

Commits on Nov 1, 2021

• Fix match_overlapping_arm false negative

  Show description for c3d4577
  

  Michael Wright

  committed
  c3d4577

• Ensure match_overlapping_arms warns on first

  

  Michael Wright

  committed
  693df63

Commits on Nov 4, 2021

• Reference nightly-rustc docs in clippy's docs

  xFrednet

  committed
  1011e08

• Improve clippy_utils function docs

  xFrednet

  committed
  d134ddd

• Add clippy docs to check for a specific type

  xFrednet

  committed
  a276cd2

• Added note about the usage of clippy_utils::path

  xFrednet

  committed
  5405152

• Auto merge of rust-lang#7928 - xFrednet:rust-90354-deploy-clippy-docs, r=flip1995

  Show description for 84a4ab7
  bors

  committed
  84a4ab7

• Merge commit 'e18101137866b79045fee0ef996e696e68c920b4' into clippyup

  flip1995

  committed
  e674d0a

Commits on Nov 5, 2021

• Remove rustfmt::skip attribute from register_plugins function

  flip1995

  committed
  93ffc9d

• Use Span::from_expansion instead of in_macro

  camsteffen

  committed
  14d54f0

• Auto merge of rust-lang#7909 - mikerite:fix-7816, r=camsteffen

  Show description for 85e2592
  bors

  committed
  85e2592

• Edit docs about macros

  camsteffen

  committed
  5b1b6a2

• Auto merge of rust-lang#7897 - camsteffen:in-macro, r=flip1995

  Show description for 9a60a93
  bors

  committed
  9a60a93

• Auto merge of rust-lang#7937 - flip1995:rustfmt-skip-artefact, r=Manishearth

  Show description for 445c83f
  bors

  committed
  445c83f

• Remove trim_semicolon

  camsteffen

  committed
  1c4dd8d

• Add expr_visitor util

  camsteffen

  committed
  73501da

• Factor in some expr_visitor usages

  camsteffen

  committed
  5239a90

• Remove if let check for match_ref_pats

  camsteffen

  committed
  2c7b7e8

Commits on Nov 6, 2021

• Extend author lint

  Serial-ATA

  committed
  c96cd35

• Add cargo dev lint to manually run clippy on a file

  Show description for b5bae09
  Alexendoo

  committed
  b5bae09

• Auto merge of rust-lang#7894 - Serial-ATA:extend-author-lint, r=camsteffen

  Show description for e3d1e60
  bors

  committed
  e3d1e60

• Fix Clippy with changed format_args!

  camsteffen

  committed
  9a8919d

Commits on Nov 7, 2021

• Give inline const separate DefKind

  nbdd0121

  committed
  0cb9ac2

• Auto merge of rust-lang#7917 - Alexendoo:cargo-dev-lint, r=giraffate

  Show description for 07f4f7c
  bors

  committed
  07f4f7c

• ast: Fix naming conventions in AST structures

  Show description for c063203
  petrochenkov

  committed
  c063203

• Fix ICE in undocumented_unsafe_blocks

  Serial-ATA

  committed
  2c6f03d

Commits on Nov 8, 2021

• Don't abort compilation after giving a lint error

  Show description for ac9dd36
  jyn514

  committed
  ac9dd36

• Auto merge of rust-lang#7945 - Serial-ATA:issue-7934, r=flip1995

  Show description for 6fcdf81
  bors

  committed
  6fcdf81

• Auto merge of rust-lang#7938 - camsteffen:visitors, r=xFrednet

  Show description for 94517d3
  bors

  committed
  94517d3

• Make select_* methods return Vec for TraitEngine

  fee1-dead

  committed
  6d23824

• Add MSRV to deprecated_cfg_attr

  Serial-ATA

  committed
  413d255

Commits on Nov 9, 2021

• Auto merge of rust-lang#7944 - Serial-ATA:deprecated-cfg-attr-msrv, r=giraffate

  Show description for 830f220
  bors

  committed
  830f220

• Fix explicit_counter_loop suggestion for non-usize types

  Serial-ATA

  committed
  6809234

• Remove unimplemented!() case in matches code

  Show description for 98416d7
  

  Michael Wright

  committed
  98416d7

• Change Bound to EndBound

  Show description for 949b259
  

  Michael Wright

  committed
  949b259

• Simplify range comparison code

  Show description for f829523
  

  Michael Wright

  committed
  f829523

• Improve variable naming

  

  Michael Wright

  committed
  c8f909e

• Improve variable naming 2

  

  Michael Wright

  committed
  81fa758

• matches: remove pub from some items

  Show description for 8b76915
  

  Michael Wright

  committed
  8b76915

• Auto merge of rust-lang#90485 - camsteffen:fmt-args-less-bind, r=m-ou-se

  Show description for 6536c58
  bors

  committed
  6536c58

• Auto merge of rust-lang#87337 - jyn514:lint-error, r=oli-obk,flip1995

  Show description for 0332a7b
  bors

  committed
  0332a7b

• Auto merge of rust-lang#90700 - fee1-dead:select-returns-vec, r=davidtwco

  Show description for 36d5475
  bors

  committed
  36d5475

• Fix suggestion for deref expressions in redundant_pattern_matching

  Serial-ATA

  committed
  e54c341

• Auto merge of rust-lang#7949 - Serial-ATA:issue-7921, r=flip1995

  Show description for c94d62b
  bors

  committed
  c94d62b

• Lint for bool to integer casts in cast_lossless

  5225225

  committed
  3382201

• fix dogfood lint on clippy_utils

  5225225

  committed
  96db1d6

• Check MSRV for bool to int from impl

  5225225

  committed
  6e84f00

• Rollup merge of rust-lang#89561 - nbdd0121:const_typeck, r=nikomatsakis

  Show description for 3b6b1ab
  matthiaskrgr

  authored
  3b6b1ab

• Auto merge of rust-lang#7950 - Serial-ATA:issue-7920, r=llogiq

  Show description for f69721f
  bors

  committed
  f69721f

• Auto merge of rust-lang#7951 - mikerite:matches-20211109, r=llogiq

  Show description for 93f13d5
  bors

  committed
  93f13d5

Commits on Nov 10, 2021

• Add semicolon_if_nothing_returned test for let-else stmts

  dswij

  committed
  e8861c8

• semicolon_if_nothing_returned now checks if the stmt ends with semicolon

  dswij

  committed
  a003ca6

• Auto merge of rust-lang#7955 - dswij:let-else-early-return, r=giraffate

  Show description for 2e17035
  bors

  committed
  2e17035

• Added clippy::version attribute as lint metadata

  xFrednet

  committed
  7c1e62d

• Add clippy version to Clippy's lint list

  xFrednet

  committed
  8565fc4

• Document new clippy::version attribute and make it mandatory

  xFrednet

  committed
  23ed792

• Manually add clippy::version attribute to deprecated lints

  xFrednet

  committed
  63cb410

• Added clippy::version attribute to all normal lints

  Show description for d647696
  xFrednet

  committed
  d647696

• Add lint to check for invalid clippy:version attributes

  xFrednet

  committed
  9d9d06d

• Updated version label and style on Clippy's lint list

  xFrednet

  committed
  d68408f

• Address review feedback

  xFrednet

  committed
  94bc0a1

• author: name qpath consistently

  camsteffen

  committed
  ce01346

• author: fix some bugs

  camsteffen

  committed
  d0cc201

• author: reorder match arm

  camsteffen

  committed
  a806ce7

• author: Remove needless refs

  camsteffen

  committed
  72d7b9c

Commits on Nov 11, 2021

• Refactor utils on checking attribute

  Show description for 847a95b
  dswij

  committed
  847a95b

• Check for no_std and no_core attribute in swap lint

  Show description for 2d037aa
  dswij

  committed
  2d037aa

• Add test for swap lint when no_std is present

  Show description for dcd1a16
  dswij

  committed
  dcd1a16

• Auto merge of rust-lang#7877 - dswij:no-std-fp, r=camsteffen

  Show description for 8389df9
  bors

  committed
  8389df9

• New internal lint to make clippy::version attribute mandatory

  xFrednet

  committed
  8c45fd8

• Auto merge of rust-lang#7813 - xFrednet:6492-lint-version, r=flip1995

  Show description for 3bfe98d
  bors

  committed
  3bfe98d

• Make author DRYer

  camsteffen

  committed
  27a1763

• New index_refutable_slice lint

  Show description for e444cbe
  xFrednet

  committed
  e444cbe

• Auto merge of rust-lang#7643 - xFrednet:7569-splits-for-slices, r=camsteffen

  Show description for 3d4d0cf
  bors

  committed
  3d4d0cf

• Auto merge of rust-lang#7956 - camsteffen:author, r=llogiq

  Show description for 8b84a76
  bors

  committed
  8b84a76

Commits on Nov 12, 2021

• Use rustfmt version from rust-toolchain

  Jarcho

  committed
  24d561f

• Auto merge of rust-lang#7963 - Jarcho:dev_fmt, r=flip1995

  Show description for 610b381
  bors

  committed
  610b381

• Change cast_lossless message for bools only

  5225225

  committed
  d4c8cb6

• Auto merge of rust-lang#7948 - 5225225:castlosslessbool, r=llogiq

  Show description for 4f82dd8
  bors

  committed
  4f82dd8

• Add rustfmt component to rust-toolchain

  Alexendoo

  committed
  91fe265

• Run clippy_dev workflow on current rust-toolchain

  Alexendoo

  committed
  608c9e8

• Run rustfmt on batches of multiple files

  Alexendoo

  committed
  507030f

• Auto merge of rust-lang#7966 - Alexendoo:batch-rustfmt, r=camsteffen

  Show description for cc9d7ff
  bors

  committed
  cc9d7ff

Commits on Nov 13, 2021

• Fix manual_map suggestion when used with unsafe functions and unsafe blocks.

  Jarcho

  committed
  80a263d

• fix typo

  togami2864

  committed
  1df10f0

• Auto merge of rust-lang#7969 - togami2864:fix-typo, r=xFrednet

  Show description for f51fb34
  bors

  committed
  f51fb34

• fix suggestion in option_map_or_none

  togami2864

  committed
  2ed4a8a

• option_if_let_else: don't expand macros in suggestion

  Show description for 3fe11e7
  matthiaskrgr

  committed
  3fe11e7

Commits on Nov 14, 2021

• Fix specific code outlined in issue rust-lang#7975.

  Show description for 3e20e30
  Blckbrry-Pi

  committed
  3e20e30

Commits on Nov 15, 2021

• Support suggestion for rust-lang#7854

  Show description for 634e79c
  surechen

  committed
  634e79c

• Auto merge of rust-lang#7957 - surechen:fix_for_7854, r=giraffate

  Show description for f82bf47
  bors

  committed
  f82bf47

• add test case for option_map_or_none

  togami2864

  committed
  4f71ff3

• Auto merge of rust-lang#7974 - matthiaskrgr:7973_opt_map_or_else_dont_expand_sugg_macro, r=flip1995

  Show description for 0def42f
  bors

  committed
  0def42f

• add reduce_unit_expression

  togami2864

  committed
  bbffe82

• fix a bug that the closure arguments are not displayed

  togami2864

  committed
  02e0726

• add comment

  togami2864

  committed
  cd57816

• fix fmt

  togami2864

  committed
  300282c

• move the let statement out of the macro

  togami2864

  committed
  0a30fdc

• Improve needless_borrow lint.

  Show description for 8ded385
  Jarcho

  committed
  8ded385

Commits on Nov 16, 2021

• Improve heuristics for determining whether eager of lazy evaluation is preferred

  Jarcho

  committed
  2938ffd

• Auto merge of rust-lang#7639 - Jarcho:whitelist_cheap_functions, r=camsteffen

  Show description for 5b1b65b
  bors

  committed
  5b1b65b

• resolve CI

  togami2864

  committed
  7605bac

• Successfully generalize prevention of suggestions causing multiple mutable borrows.

  Show description for 5b3c00f
  Blckbrry-Pi

  committed
  5b3c00f

• Fix readability suggestions.

  Show description for c52b389
  Blckbrry-Pi

  committed
  c52b389

• Auto merge of rust-lang#7982 - Blckbrry-Pi:master, r=llogiq

  Show description for 83ad511
  bors

  committed
  83ad511

• Don't show no_effect warning on unit structs implementing fn* traits

  F3real

  committed
  e9bf5ec

Commits on Nov 17, 2021

• fixes: rust-lang#7889

  Show description for c051656
  surechen

  committed
  c051656

• Auto merge of rust-lang#7896 - surechen:fix_manual_split_once, r=camsteffen

  Show description for 46687f1
  bors

  committed
  46687f1

• Fix ICE on undocumented_unsafe_blocks

  giraffate

  committed
  3f3d7c2

• Auto merge of rust-lang#7898 - F3real:unit_struct, r=camsteffen

  Show description for 94ca94f
  bors

  committed
  94ca94f

• add multi-line test case

  togami2864

  committed
  e34927e

• Auto merge of rust-lang#7988 - giraffate:fix_ice_on_undocumented_unsafe_blocks, r=flip1995

  Show description for d550e5f
  bors

  committed
  d550e5f

• check whether stmts is empty or not in block

  togami2864

  committed
  006c442

• Minor simplification to manual_map

  Jarcho

  committed
  8506f66

• Addition manual_map test for unsafe blocks

  Jarcho

  committed
  5f861ee

• fix suggestion message

  togami2864

  committed
  8e317f5

• Auto merge of rust-lang#7971 - togami2864:fix/option-map-or-none, r=llogiq

  Show description for 6ac42fe
  bors

  committed
  6ac42fe

• Auto merge of rust-lang#7968 - Jarcho:manual_map_unsafe, r=xFrednet

  Show description for bb58dc8
  bors

  committed
  bb58dc8

Commits on Nov 18, 2021

• rustc: Remove #[rustc_synthetic]

  Show description for cb62680
  petrochenkov

  committed
  cb62680

• fix typo

  togami2864

  committed
  b5a61aa

• Auto merge of rust-lang#7992 - togami2864:fix-typo, r=giraffate

  Show description for 8536647
  bors

  committed
  8536647

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  731dfde

• Bump nightly version -> 2021-11-18

  flip1995

  committed
  4bccd59

• Auto merge of rust-lang#7994 - flip1995:rustup, r=flip1995

  Show description for 8dd1bce
  bors

  committed
  8dd1bce

• Pluralize disallowed_type lint

  Show description for b7f1891
  

  phansch

  authored and

  flip1995

  committed
  b7f1891

• Pluralize disallowed_type lint filenames

  Show description for a0d81d1
  

  phansch

  authored and

  flip1995

  committed
  a0d81d1

• Also pluralize disallowed_method(s) lint

  Show description for 9b38fb7
  flip1995

  committed
  9b38fb7

• Add missing components to rust-toolchain file

  couchand

  committed
  0375d20

• Auto merge of rust-lang#7977 - Jarcho:multi_needless_borrow, r=xFrednet

  Show description for 2776076
  bors

  committed
  2776076

Commits on Nov 19, 2021

• add test case for result_map_or_into_option

  togami2864

  committed
  abb7155

• fix stderr

  togami2864

  committed
  cd81bb9

• Auto merge of rust-lang#7996 - togami2864:test-map-or-none, r=Manishearth

  Show description for 0d283cc
  bors

  committed
  0d283cc

• Auto merge of rust-lang#7984 - phansch:disallowed-type-rename, r=xFrednet

  Show description for 38bd251
  bors

  committed
  38bd251

Commits on Nov 20, 2021

• Don't check for a nightly toolchain in fmt test

  Jarcho

  committed
  1429949

• Add new lint octal_escapes

  Show description for 982124a
  birkenfeld

  committed
  982124a

• Auto merge of rust-lang#8000 - Jarcho:nightly_fmt, r=llogiq

  Show description for 827fd50
  bors

  committed
  827fd50

• Allow suboptimal_flops in const functions

  xFrednet

  committed
  1c8085d

• Avoid inline hints with double backticks for doc-markdown

  birkenfeld

  committed
  0c4055c

• Auto merge of rust-lang#8011 - birkenfeld:double_backticks, r=xFrednet

  Show description for 32048eb
  bors

  committed
  32048eb

Commits on Nov 21, 2021

• Fixes rust-lang#7915

  Show description for 846c0be
  surechen

  committed
  846c0be

• Inhibit clicks on summary's children

  Show description for 9aef9a2
  jsha

  committed
  9aef9a2

• Fix Clippy with changed for loop desugar

  camsteffen

  committed
  e58ffb8

• clippy: Fix pattern_type_mismatch for loop

  camsteffen

  committed
  8c1c763

• Auto merge of rust-lang#7997 - surechen:Fixes_7915, r=giraffate

  Show description for de2208a
  bors

  committed
  de2208a

Commits on Nov 22, 2021

• Auto merge of rust-lang#8009 - xFrednet:8004-suboptimal-flops-in-const, r=giraffate

  Show description for 5fbfdfa
  bors

  committed
  5fbfdfa

• Add GUI test for clicking on non-toggle summary

  jsha

  committed
  7f35556

• Auto merge of rust-lang#7989 - couchand:2021-11/toolchain-missing-components, r=flip1995

  Show description for 4027594
  bors

  committed
  4027594

• octal_escapes: updates from review, fix byte string prefix

  birkenfeld

  committed
  850e7f5

• Give people a single link they can click in the contributing guide

  Show description for bb7ec7b
  jyn514

  committed
  bb7ec7b

• octal_escapes: emit only one lint for all cases found each literal

  birkenfeld

  committed
  0bc25d0

• octal_escapes: note on print!() format strings

  birkenfeld

  committed
  1210bb4

• Auto merge of rust-lang#8007 - birkenfeld:octal_escapes, r=xFrednet

  Show description for 57a8804
  bors

  committed
  57a8804

• Split inline const to two feature gates

  nbdd0121

  committed
  6d61d87

• #![feature(inline_const)] is no longer incomplete

  nbdd0121

  committed
  6f38568

Commits on Nov 23, 2021

• Use derive_default_enum in the compiler

  jhpratt

  committed
  7b103e7

• Fix FP on if_then_some_else_none when there is early return

  dswij

  committed
  ec3d1c8

• fix test in std::process on android

  name1e5s

  committed
  08a500f

• Make intrinsics::write_bytes const

  lilasta

  committed
  e8e02d9

• Auto merge of rust-lang#7980 - dswij:7870, r=xFrednet

  Show description for d6c707d
  bors

  committed
  d6c707d

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  5740230

• Bump nightly version -> 2021-11-23

  flip1995

  committed
  c46c8c5

• Auto merge of rust-lang#8025 - flip1995:rustup, r=flip1995

  Show description for 81f37a8
  bors

  committed
  81f37a8

• Merge commit '81f37a8150fc86f8de00e6947e86d2b69291906a' into clippyup

  flip1995

  committed
  1ee5aa4

• Update Cargo.lock

  flip1995

  committed
  b95545b

• Rollup merge of rust-lang#90081 - woppopo:const_write_bytes, r=oli-obk

  Show description for aa73065
  matthiaskrgr

  authored
  aa73065

• Rollup merge of rust-lang#91103 - jsha:non-toggle-click-doesnt-toggle, r=Manishearth,GuillaumeGomez

  Show description for 58269a6
  matthiaskrgr

  authored
  58269a6

• Rollup merge of rust-lang#91137 - jyn514:contributing, r=spastorino

  Show description for 39542a0
  matthiaskrgr

  authored
  39542a0

• Rollup merge of rust-lang#91140 - nbdd0121:const_typeck, r=oli-obk

  Show description for ccc53bb
  matthiaskrgr

  authored
  ccc53bb

• Rollup merge of rust-lang#91148 - jhpratt:use-default-enum, r=petrochenkov

  Show description for 80bb3c0
  matthiaskrgr

  authored
  80bb3c0

• Rollup merge of rust-lang#91151 - name1e5s:chore/process_test, r=m-ou-se

  Show description for 5c8ed8f
  matthiaskrgr

  authored
  5c8ed8f

• Rollup merge of rust-lang#91154 - flip1995:clippyup, r=Manishearth

  Show description for c9ce710
  matthiaskrgr

  authored
  c9ce710