Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for #91489 #91495

Closed
wants to merge 2 commits into from
Closed

Add regression test for #91489 #91495

wants to merge 2 commits into from

Conversation

SNCPlay42
Copy link
Contributor

@SNCPlay42 SNCPlay42 commented Dec 3, 2021 •
edited by fee1-dead
Loading

Add a regression test for #91489.

This is based on #91491 and should not be merged before it.

r? @spastorino

@rust-highfive
Copy link
Collaborator

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2021
@SNCPlay42
Copy link
Contributor Author

SNCPlay42 commented Dec 3, 2021 •
edited
Loading

That's just because this PR incorporates #91491, sorry for the pings! I hope I did this right.

@fee1-dead
Copy link
Member

fee1-dead commented Dec 3, 2021 •
edited
Loading

The issue should not be closed when this is merged. We should close it once we have the actual fix along with a revert of the revert.

I've edited your description so it doesn't automatically close the issue when the PR is merged.

@spastorino
Copy link
Member

@SNCPlay42 can you rebase this on top of master? in particular on top of my revert? I guess it would be great if we merge this one before #91549.

@spastorino
Copy link
Member

Or we could even incorporate this PR into #91549. cc @fee1-dead

@fee1-dead
Copy link
Member

It's already incorporated: https://github.com/rust-lang/rust/pull/91549/files#diff-e34c957fc46eeb0763070c3cafd7b54343290bbb051f764866de01b9b6ec87aa

@spastorino
Copy link
Member

Ohh I see, can you keep @SNCPlay42 as the author?, so we give credit to them :). I guess we can also close this PR then.

@fee1-dead
Copy link
Member

Rebased and cherry-picked the commit :)

@fee1-dead fee1-dead closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SNCPlay42 @rust-highfive @fee1-dead @spastorino