Add deprecation warning for --passes #91717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @jyn514 |
jyn514
added
the
T-rustdoc
jyn514
suggested changes
Dec 9, 2021
There was a problem hiding this comment.
Can you add a test for the new behavior? It should go in src/test/rustdoc-ui and test that a warning is emitted when you add // compile-flags: --passes list at the top` - see https://rustc-dev-guide.rust-lang.org/tests/adding.html#guide-to-the-ui-tests for documentation on how tests work.
jyn514
added
S-waiting-on-author
jyn514
reviewed
Dec 9, 2021
Co-authored-by: Joshua Nelson <github@jyn.dev>
jyn514
added
S-waiting-on-review
|
@bors r+ Thanks! |
|
📌 Commit 2b6987d has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 9, 2021
Add deprecation warning for --passes Issue rust-lang#91713 mentored by `@jyn514`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 10, 2021
Add deprecation warning for --passes Issue rust-lang#91713 mentored by ``@jyn514``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91617 (Improve the readability of `List<T>`.) - rust-lang#91640 (Simplify collection of in-band lifetimes) - rust-lang#91682 (rustdoc: Show type layout for type aliases) - rust-lang#91711 (Improve `std::iter::zip` example) - rust-lang#91717 (Add deprecation warning for --passes) - rust-lang#91718 (give more help in the unaligned_references lint) - rust-lang#91782 (Correct since attribute for `is_symlink` feature) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #91713 mentored by @jyn514