link to pref_align_of tracking issue #91972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -811,7 +811,8 @@ extern "rust-intrinsic" { | |||
| /// The preferred alignment of a type. | |||
| /// | |||
| /// This intrinsic does not have a stable counterpart. | |||
| #[rustc_const_unstable(feature = "const_pref_align_of", issue = "none")] | |||
| /// It's "tracking issue" is [#91971](https://github.com/rust-lang/rust/issues/91971). | |||
| #[rustc_const_unstable(feature = "const_pref_align_of", issue = "91971")] | |||
There was a problem hiding this comment.
I guess this just affects the const tracking issue -- seems OK for now.
|
@bors r+ rollup |
|
📌 Commit 58fd2ff has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 15, 2021
…lacrum link to pref_align_of tracking issue If we are not going to remove this intrinsic (rust-lang#90877), I think we should at least have a place to centralize discussion around it, so here we go. Intrinsics don't have their own separate features and usually we instead use the public method for tracking it, but this one does not have such a method... so the tracking issue is just a regular link. (And then we sue it for the const part as well.)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 16, 2021
…lacrum link to pref_align_of tracking issue If we are not going to remove this intrinsic (rust-lang#90877), I think we should at least have a place to centralize discussion around it, so here we go. Intrinsics don't have their own separate features and usually we instead use the public method for tracking it, but this one does not have such a method... so the tracking issue is just a regular link. (And then we sue it for the const part as well.)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 16, 2021
…lacrum link to pref_align_of tracking issue If we are not going to remove this intrinsic (rust-lang#90877), I think we should at least have a place to centralize discussion around it, so here we go. Intrinsics don't have their own separate features and usually we instead use the public method for tracking it, but this one does not have such a method... so the tracking issue is just a regular link. (And then we sue it for the const part as well.)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 16, 2021
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#91901 (Remove `in_band_lifetimes` from `rustc_symbol_mangling`) - rust-lang#91904 (Remove `in_band_lifetimes` from `rustc_trait_selection`) - rust-lang#91951 (update stdarch) - rust-lang#91958 (Apply rust-logo class only on default logo) - rust-lang#91972 (link to pref_align_of tracking issue) - rust-lang#91986 (Bump compiler-builtins to 0.1.66) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are not going to remove this intrinsic (#90877), I think we should at least have a place to centralize discussion around it, so here we go. Intrinsics don't have their own separate features and usually we instead use the public method for tracking it, but this one does not have such a method... so the tracking issue is just a regular link. (And then we sue it for the const part as well.)