Fix Rust build on mingw v4.0 #9254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cribed in rust-lang#9246. This works by adding this directory to GCC include search path before mingw system headers directories, so we can intercept their inclusions and add missing definitions without having to modify files in mingw/include.
…change (rust-lang#9205). These really should have been marked xfail-win32, but that doesn't exist, so xfail-fast it is.
|
@brson: r? |
|
I think this should use xfail-win32 instead. |
|
This looks good to me btw, but I think that we should move windows forward soon so these don't start to bitrot. |
bors
added a commit
that referenced
this pull request
Sep 18, 2013
Fix Rust build on mingw v4.0 See #9246 for details.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 11, 2022
…_on_windows, r=dswij Enable test empty_loop_no_std on windows Verified that it actully works on windows changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Rust build on mingw v4.0
See #9246 for details.