document what unsafety means #9258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| This is a list of behaviour `unsafe` blocks/functions *must prevent*. These issues cannot be caused | ||
| by safe code, if all interfaces using `unsafe` code internally are correct. | ||
|
|
There was a problem hiding this comment.
This reads a bit passive in my opinion. These two sentences should be reworded to make the warning about unsafeness and the rules to follow more clear:
This is a list of behavior that must never occur in a rust program. You can cause them with unsafe blocks/functions, so while writing those you have to take care to prevent them. All safe rust code is build on the trust that all interfaces using unsafe code internally are correct, and only if you uphold that trust do you get the guarantee that safe code will never cause those issues.
bors
added a commit
that referenced
this pull request
Sep 18, 2013
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 29, 2022
Add [`unused_peekable`] lint changelog: Add [`unused_peekable`] lint closes: rust-lang#854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9144