Merge "Structs", "Enums", etc. sections into new "Types" section #92660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
Does this need a runtime ID redirect as well? The only links that should break are links to the |
camelid
force-pushed
the
merge-type-sections
branch
from
9f39a3a to
0f7603c
Compare
Before
After
|
|
For some reason, all the links are blue now. I don't see how that could result from my change though, so maybe this regressed on master but isn't on nightly yet? EDIT: Fixed. |
|
Hmm, master hasn't been pushed to since yesterday though... |
This comment has been minimized.
This comment has been minimized.
jsha
reviewed
Jan 8, 2022
camelid
added
S-waiting-on-author
The new code is much simpler and easier to understand. In fact, the old code actually had a subtle bug where it excluded a few item types, including trait aliases, from the sidebar, even though they are rendered on the page itself! Now, all sections should show up in the sidebar.
camelid
force-pushed
the
merge-type-sections
branch
from
0f7603c to
63fd743
Compare
This comment has been minimized.
This comment has been minimized.
camelid
force-pushed
the
merge-type-sections
branch
from
63fd743 to
91274d3
Compare
|
Hmm, looks like the types aren't sorted within their section... |
| ItemType::Function => 10, | ||
| ItemType::Typedef => 12, | ||
| ItemType::Union => 13, | ||
| ItemType::Typedef => 7, |
There was a problem hiding this comment.
I think this change will impact the search.
There was a problem hiding this comment.
This is only used for rendering module pages I'm pretty sure?
There was a problem hiding this comment.
Indeed, nevermind. I thought it was the mapping for the search index types...
|
The job Click to see the possible cause of the failure (guessed by this bot) |
1 similar comment
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Looks like GUI tests are failing. I'd love to get this landed. I think it's a very nice simplification. @camelid any chance you'll have time soon to fix the tests? |
|
Yeah, I'm a bit busy this week, but I'm planning to return to this soon. |
|
This is a step backwards in usability and discovery. The corresponding issue has more downvotes than upvotes. Please do not merge this. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 10, 2022
…llaumeGomez Refactor sidebar printing code This is the refactoring parts of rust-lang#92660, plus the trait aliases capitalization consistency fix. I think this will be necessary for rust-lang#92658. r? `@GuillaumeGomez`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92656.
r? @GuillaumeGomez
cc @jsha