Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_codegen_llvm: Remove (almost) unused span parameter from many functions in metadata.rs #92729

Merged
merged 1 commit into from
Jan 18, 2022
Merged

rustc_codegen_llvm: Remove (almost) unused span parameter from many functions in metadata.rs #92729

merged 1 commit into from
Jan 18, 2022

Conversation

michaelwoerister
Copy link
Member

Many functions and intermediate data structures in rustc_codegen_llvm/src/debuginfo/metadata.rs take a span parameter that is only used for providing a span to a span_bug!() invocation, in case the debuginfo typemap gets corrupted. However, this span does not really convey useful information as it just points to the first point a type is used -- and half of the time is initialized to DUMMY_SP.

This PR removes this span parameter from the module.

It also removes the following unused parameters from composite_type_metadata() together with an outdated comment:

    // Ignore source location information as long as it
    // can't be reconstructed for non-local crates.
    _file_metadata: &'ll DIFile,
    _definition_span: Span,

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 10, 2022
@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2022
@michaelwoerister
Copy link
Member Author

Let's make sure there are no surprises: @bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 10, 2022
@bors
Copy link
Contributor

bors commented Jan 10, 2022

⌛ Trying commit 7fdfdf17c96b5b27448b81cc5acf7d404b5effcc with merge d1a1b735bf4a1b9f622d8ac62b3b6d62ce3560c2...

@bors
Copy link
Contributor

bors commented Jan 10, 2022

☀️ Try build successful - checks-actions
Build commit: d1a1b735bf4a1b9f622d8ac62b3b6d62ce3560c2 (d1a1b735bf4a1b9f622d8ac62b3b6d62ce3560c2)

@rust-timer
Copy link
Collaborator

Queued d1a1b735bf4a1b9f622d8ac62b3b6d62ce3560c2 with parent 89b9f7b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d1a1b735bf4a1b9f622d8ac62b3b6d62ce3560c2): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 10, 2022
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 12, 2022

📌 Commit 7fdfdf17c96b5b27448b81cc5acf7d404b5effcc has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2022
@bors
Copy link
Contributor

bors commented Jan 12, 2022

☔ The latest upstream changes (presumably #92811) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2022
@michaelwoerister michaelwoerister force-pushed the remove-unused-span-debuginfo branch from 7fdfdf1 to 9a79ab6 Compare January 17, 2022 15:43
@michaelwoerister
Copy link
Member Author

Rebased.

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Jan 17, 2022

📌 Commit 9a79ab6 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 17, 2022
@michaelwoerister michaelwoerister mentioned this pull request Jan 17, 2022
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2022
@bors
Auto merge of rust-lang#93009 - matthiaskrgr:rollup-3fkxg6i, r=matthi…
86b1581 
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#90498 (Clarifications in the target tier policy)
 - rust-lang#92164 (Implement `#[rustc_must_implement_one_of]` attribute)
 - rust-lang#92729 (rustc_codegen_llvm: Remove (almost) unused span parameter from many functions in metadata.rs)
 - rust-lang#92752 (Correct minor typos in some long error code explanations)
 - rust-lang#92801 (Enable wrapping words by default)
 - rust-lang#92825 (Rename environment variable for overriding rustc version)
 - rust-lang#92877 (Remove LLVMRustMarkAllFunctionsNounwind)
 - rust-lang#92936 (rustdoc: Remove `collect` in `html::markdown::parse`)
 - rust-lang#92956 (Add `log2` and `log10` to `NonZeroU*`)
 - rust-lang#92960 (Use `carrying_{mul|add}` in `num::bignum`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 97743d9 into rust-lang:master Jan 18, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 18, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2022
@matthiaskrgr
Rollup merge of rust-lang#93006 - michaelwoerister:fix-unsized-ptr-de…
9681796 
…buginfo, r=davidtwco,oli-obk

Fix debuginfo for pointers/references to unsized types

This PR makes the compiler emit fat pointer debuginfo in all cases. Before, we sometimes got thin-pointer debuginfo, making it impossible to fully interpret the pointed to memory in debuggers. The code is actually cleaner now, especially around generation of trait object pointer debuginfo.

Fixes rust-lang#92718

~~Blocked on rust-lang#92729
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2022
@bors
Auto merge of rust-lang#93006 - michaelwoerister:fix-unsized-ptr-debu…
427eba2 
…ginfo, r=davidtwco,oli-obk

Fix debuginfo for pointers/references to unsized types

This PR makes the compiler emit fat pointer debuginfo in all cases. Before, we sometimes got thin-pointer debuginfo, making it impossible to fully interpret the pointed to memory in debuggers. The code is actually cleaner now, especially around generation of trait object pointer debuginfo.

Fixes rust-lang#92718

~~Blocked on rust-lang#92729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
6 participants
@michaelwoerister @rust-highfive @rust-timer @bors @petrochenkov @rustbot