Allow for integral suffixes after a char literal #9302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way you can say 'a'u8 instead of ('a' as u8).
|
This is a language change, and I don't agree with the syntax used here. I think this needs to go through the RFC process. |
|
@thestinger Fair enough. What's the RFC process? FWIW, this was motivated by an IRC conversation 2 days ago where @pcwalton expressed support for |
|
Usually you would open an issue with RFC in the title (and it would be tagged as an RFC) but in this case #4334 is open about adding byte string/character literals. The syntax hasn't been agreed upon yet though. |
|
Closing for now, for it to be hashed out in the RFC issue. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 11, 2022
Move `significant_drop_in_scrutinee` into `nursey`
The current suggestion of extending the lifetime of every sub-expression is not great and doesn't fix the error given in the lint's example, though it does make the potential deadlock easier to see, but it can also cause it's own issues by delaying the drop of the lock guard.
e.g.
```rust
match x.lock().foo {
..
}
// some stuff
let y = x.lock();
```
The suggestion would create a deadlock at the second `x.lock()` call.
This also lints even when a significant drop type isn't created as a temporary. (rust-lang#9072)
I agree `@kpreid` (rust-lang/rust-clippy#8987 (comment)) that this should be back-ported before the lint hits stable.
changelog: Move `significant_drop_in_scrutinee` into `nursey`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way you can say 'a'u8 instead of ('a' as u8).