Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete Stdin::split forwarder #93134

Merged
merged 1 commit into from
Jan 22, 2022
Merged

delete Stdin::split forwarder #93134

merged 1 commit into from
Jan 22, 2022

Conversation

tlyu
Copy link
Contributor

@tlyu tlyu commented Jan 20, 2022

Part of #87096. Delete the Stdin::split forwarder because it's seen as too niche to expose at this level.

@rustbot label T-libs-api A-io

@rustbot rustbot added A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jan 20, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 20, 2022
@tlyu tlyu mentioned this pull request Jan 20, 2022
Closed
4 tasks
@Amanieu
Copy link
Member

Amanieu commented Jan 20, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 20, 2022

📌 Commit fdf930c has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 21, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2022
@bors
Auto merge of rust-lang#93173 - matthiaskrgr:rollup-49bj7ta, r=matthi…
ecf7299 
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#91965 (Add more granular `--exclude` in `x.py`)
 - rust-lang#92467 (Ensure that early-bound function lifetimes are always 'local')
 - rust-lang#92586 (Set the allocation MIN_ALIGN for espidf to 4.)
 - rust-lang#92835 (Improve error message for key="value" cfg arguments.)
 - rust-lang#92843 (Improve string concatenation suggestion)
 - rust-lang#92963 (Implement tuple array diagnostic)
 - rust-lang#93046 (Use let_else in even more places)
 - rust-lang#93109 (Improve `Arc` and `Rc` documentation)
 - rust-lang#93134 (delete `Stdin::split` forwarder)
 - rust-lang#93139 (rustdoc: fix overflow-wrap for table layouts)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 081d65f into rust-lang:master Jan 22, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 22, 2022
@tlyu tlyu deleted the delete-stdin-split branch January 24, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tlyu @rust-highfive @Amanieu @bors @Mark-Simulacrum @rustbot