Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drop tracking ICEs and re-enable generator drop tracking #93180

Closed
wants to merge 7 commits into from
Closed

Fix drop tracking ICEs and re-enable generator drop tracking #93180

wants to merge 7 commits into from
+127 −102

Commits on Feb 1, 2022

  1. Reduce regression test

    @eholk
    eholk committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    cc9f16b View commit details
    Browse the repository at this point in the history

  2. Allow uninhabited types in generator interiors 

    Drop tracking in the generator interior type checking pass would count
all values in unreachable code as dropped (e.g. code after a call to a
function with an uninhabited return type), which would lead to those
values not being included in the witness type. This resulted in the type
checker being more precise than the corresponding sanity check in the
MIR transform.

This patch changes the check in the MIR code to match the results of
typeck by skipping uninhabited types.
    @eholk
    eholk committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    f77a407 View commit details
    Browse the repository at this point in the history

  3. Support break and continue with block targets 

    Issue rust-lang#93197
    @eholk
    eholk committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    06d5a96 View commit details
    Browse the repository at this point in the history

  4. Apply code review comments

    @eholk
    eholk committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    0c7f1f9 View commit details
    Browse the repository at this point in the history

  5. Apply code review suggestion better

    @eholk
    eholk committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    44ca6bc View commit details
    Browse the repository at this point in the history

  6. Re-enable drop tracking

    @eholk
    eholk committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    f462bca View commit details
    Browse the repository at this point in the history

  7. Handle Continue correctly

    @eholk
    eholk committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    e5b2270 View commit details
    Browse the repository at this point in the history