#[rustc_pass_by_value] cleanup
#93363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -61,6 +61,9 @@ use rustc_data_structures::fx::FxIndexSet; | |||
| /// using the callback `SPAN_TRACK` to access the query engine. | |||
| /// | |||
| #[derive(Clone, Copy, Eq, PartialEq, Hash)] | |||
| // FIXME(@lcnr): Enable this attribute once the bootstrap | |||
| // compiler knows of `rustc_pass_by_value`. | |||
| // #[cfg_attr(not(bootstrap), rustc_pass_by_value)] | |||
There was a problem hiding this comment.
Suggested change
| // #[cfg_attr(not(bootstrap), rustc_pass_by_value)] | |
| #[cfg_attr(not(bootstrap), rustc_pass_by_value)] |
Why doesn't this work? Isn't not(bootstrap) supposed to specifically address this case?
There was a problem hiding this comment.
&Span is used incredibly frequently, so fixing it takes a while. As long as rustc_pass_by_value is ignored in the bootstrap compiler, it isn't as nice to deal with that.
It means that the lint will only trigger when compiling the stage 2 compiler, which most people don't tend to do before submitting their PR, causing CI to break. So it would work, but would imo be too annoying to be worth it.
There was a problem hiding this comment.
Could you say in the comment that not all uses of Span are fixed, and it's tedious to fix them until it can be done at stage 0-1 when stage 0-1 supports #[rustc_pass_by_value]?
Right now it's entirely unclear from the comment why the attribute is commented out.
petrochenkov
added
S-waiting-on-author
lcnr
added
S-waiting-on-review
|
r=me with the comment extended (#93363 (comment)). |
petrochenkov
added
S-waiting-on-author
|
@bors r=petrochenkov rollup=always |
|
📌 Commit 2684dfe has been approved by |
bors
added
S-waiting-on-bors
|
why does CI segfault here and in #93267? that seems weird 🤔 cc @rust-lang/infra do you know what's going on here? |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#91641 (Define c_char using cfg_if rather than repeating 40-line cfg) - rust-lang#92899 (Mention std::iter::zip in Iterator::zip docs) - rust-lang#93193 (Add test for stable hash uniqueness of adjacent field values) - rust-lang#93325 (Introduce a limit to Levenshtein distance computation) - rust-lang#93339 (rustdoc: add test case for multiple traits and erased names) - rust-lang#93357 (Clarify the `usage-of-qualified-ty` error message.) - rust-lang#93363 (`#[rustc_pass_by_value]` cleanup) - rust-lang#93365 (More arena cleanups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.