Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove allow_fail test flag #93416

Merged
merged 2 commits into from
Feb 7, 2022
Merged

remove allow_fail test flag #93416

merged 2 commits into from
Feb 7, 2022

Conversation

name1e5s
Copy link
Contributor

close #93345

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 28, 2022
@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@name1e5s
Copy link
Contributor Author

Hmm, it seems that we should preserve allow_fail field in TestDesc to pass the check with stage 0 compiler.

@m-ou-se
Copy link
Member

m-ou-se commented Jan 28, 2022

We should wait until the FCP in #46488 finishes, so marking this as blocked for now.

@m-ou-se m-ou-se added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 28, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Jan 28, 2022 •
edited
Loading

Hmm, it seems that we should preserve allow_fail field in TestDesc to pass the check with stage 0 compiler.

You can use #[cfg(bootstrap)] for code that should only used with the stage 0 compiler.

(Someone will remove all code marked with that attribute when the stage 0 compiler gets updated to the next beta.)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@name1e5s name1e5s force-pushed the chore/remove_allow_fail branch from c4a670e to 0b8c9fb Compare January 28, 2022 11:41
@m-ou-se m-ou-se removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Feb 7, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Feb 7, 2022

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 7, 2022

📌 Commit 0b8c9fb has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2022
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Feb 7, 2022
@m-ou-se
Rollup merge of rust-lang#93416 - name1e5s:chore/remove_allow_fail, r…
6a7a60a 
…=m-ou-se

remove `allow_fail` test flag

close rust-lang#93345
@m-ou-se m-ou-se mentioned this pull request Feb 7, 2022
Closed
@m-ou-se m-ou-se mentioned this pull request Feb 7, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2022
@bors
Auto merge of rust-lang#93738 - m-ou-se:rollup-zjyd2et, r=m-ou-se
f52c318 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#88313 (Make the pre-commit script pre-push instead)
 - rust-lang#91530 (Suggest 1-tuple parentheses on exprs without existing parens)
 - rust-lang#92724 (Cleanup c_str.rs)
 - rust-lang#93208 (Impl {Add,Sub,Mul,Div,Rem,BitXor,BitOr,BitAnd}Assign<$t> for Wrapping<$t> for rust 1.60.0)
 - rust-lang#93394 (Don't allow {} to refer to implicit captures in format_args.)
 - rust-lang#93416 (remove `allow_fail` test flag)
 - rust-lang#93487 (Fix linking stage1 toolchain in `./x.py setup`)
 - rust-lang#93673 (Linkify sidebar headings for sibling items)
 - rust-lang#93680 (Drop json::from_reader)
 - rust-lang#93682 (Update tracking issue for `const_fn_trait_bound`)
 - rust-lang#93722 (Use shallow clones for submodules managed by rustbuild, not just bootstrap.py)
 - rust-lang#93723 (Rerun bootstrap's build script when RUSTC changes)
 - rust-lang#93737 (bootstrap: prefer using '--config' over 'RUST_BOOTSTRAP_CONFIG')

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 252ff5e into rust-lang:master Feb 7, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 7, 2022
@joshtriplett joshtriplett mentioned this pull request Apr 23, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request May 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.

remove allow_fail test flag
6 participants
@name1e5s @rust-highfive @rust-log-analyzer @m-ou-se @bors @rustbot