Suggest deriving required supertraits #93693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
davidtwco
requested changes
Feb 8, 2022
davidtwco
added
S-waiting-on-author
davidtwco
reviewed
Feb 16, 2022
davidtwco
approved these changes
Feb 16, 2022
|
@bors r+ |
|
📌 Commit 1973f27 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 16, 2022
Suggest deriving required supertraits closes rust-lang#91550 I chose to just hardcode handling for PartialOrd and PartialEq because that should be robust enough and I dont know how to go about doing it generically r? rust-lang/diagnostics
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 17, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#89869 (Add documentation to more `From::from` implementations.) - rust-lang#93479 (Use `optflag` for `--report-time`) - rust-lang#93693 (Suggest deriving required supertraits) - rust-lang#93981 (Fix suggestion to slice if scurtinee is a reference to `Result` or `Option`) - rust-lang#93996 (Do not suggest "is a function" for free variables) - rust-lang#94030 (Correctly mark the span of captured arguments in `format_args!()`) - rust-lang#94031 ([diagnostics] Add mentions to `Copy` types being valid for `union` fields) - rust-lang#94064 (Update dist-x86_64-musl to Ubuntu 20.04) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #91550
I chose to just hardcode handling for PartialOrd and PartialEq because that should be robust enough and I dont know how to go about doing it generically
r? rust-lang/diagnostics