Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Collect traits in scope for lang items #93766

Merged
merged 1 commit into from
Feb 18, 2022
Merged

rustdoc: Collect traits in scope for lang items #93766

merged 1 commit into from
Feb 18, 2022

Conversation

petrochenkov
Copy link
Contributor

Inherent impls on primitive types are not included in the list of all inherent impls in the crate (inherent_impls_in_crate_untracked), they are taken from the list of lang items instead, but such impls can also be inlined by rustdoc, e.g. if something derefs to a primitive type.

r? @camelid
Fixes #93698

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 8, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2022
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 8, 2022
@bors
Copy link
Contributor

bors commented Feb 8, 2022

⌛ Trying commit 8d3ccb18d466f0b958ec82922fc614a231e002ce with merge aa1ba8fdf303d25787de79bbab2d36dbf3913043...

@petrochenkov petrochenkov mentioned this pull request Feb 8, 2022
Closed
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2022
@bors
Copy link
Contributor

bors commented Feb 8, 2022

☀️ Try build successful - checks-actions
Build commit: aa1ba8fdf303d25787de79bbab2d36dbf3913043 (aa1ba8fdf303d25787de79bbab2d36dbf3913043)

@rust-timer
Copy link
Collaborator

Queued aa1ba8fdf303d25787de79bbab2d36dbf3913043 with parent 03b17b1, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aa1ba8fdf303d25787de79bbab2d36dbf3913043): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 8, 2022
@petrochenkov
Copy link
Contributor Author

@bors rollup=maybe

camelid
camelid reviewed Feb 11, 2022
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but I have a few comments.

src/test/rustdoc/intra-doc/extern-lang-item-impl.rs Show resolved Hide resolved
compiler/rustc_metadata/src/rmeta/decoder.rs Show resolved Hide resolved
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2022
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2022
@petrochenkov
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 15, 2022
camelid
camelid approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 16, 2022
@camelid
Copy link
Member

camelid commented Feb 17, 2022

@bors p=1 (fixes high priority rustdoc ICE breakage)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#93766 - petrochenkov:doclinkregr, r=camelid…
ee80f1d 
…,GuillaumeGomez

rustdoc: Collect traits in scope for lang items

Inherent impls on primitive types are not included in the list of all inherent impls in the crate (`inherent_impls_in_crate_untracked`), they are taken from the list of lang items instead, but such impls can also be inlined by rustdoc, e.g. if something derefs to a primitive type.

r? `@camelid`
Fixes rust-lang#93698
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 17, 2022
Closed
@bors
Copy link
Contributor

bors commented Feb 17, 2022

⌛ Testing commit 9c9dd20 with merge 1dbb0291e171ff054fac8ae3f0ecdd3506adcfd2...

@matthiaskrgr
Copy link
Member

@bors retry yield #94102

@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@bors
Copy link
Contributor

bors commented Feb 18, 2022

⌛ Testing commit 9c9dd20 with merge 493573589909b6e4e8463e65d1787654171d3b07...

@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2022
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2022
@petrochenkov
Copy link
Contributor Author

@bors r=camelid,GuillaumeGomez

@bors
Copy link
Contributor

bors commented Feb 18, 2022

📌 Commit 0da7adc has been approved by camelid,GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2022
@bors
Copy link
Contributor

bors commented Feb 18, 2022

⌛ Testing commit 0da7adc with merge b8c56fa...

@bors
Copy link
Contributor

bors commented Feb 18, 2022

☀️ Test successful - checks-actions
Approved by: camelid,GuillaumeGomez
Pushing b8c56fa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 18, 2022
@bors bors merged commit b8c56fa into rust-lang:master Feb 18, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 18, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b8c56fa): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@lcnr lcnr mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid approved these changes

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@camelid camelid

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.

rustdoc ICE: 'no entry found for key' with static referencing external type
9 participants
@petrochenkov @rust-timer @bors @camelid @matthiaskrgr @rust-log-analyzer @GuillaumeGomez @rust-highfive @rustbot