Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve chalk integration #93810

Merged
merged 6 commits into from
Feb 13, 2022
Merged

Improve chalk integration #93810

merged 6 commits into from
Feb 13, 2022

Commits on Feb 11, 2022

  1. Stop using a placeholder for empty regions in Chalk

    @matthewjasper
    matthewjasper committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    cb3cff3 View commit details
    Browse the repository at this point in the history

  2. Fix more chalk lowering issues 

    - Implement lowering for subtype goals
- Use correct lang item for Generator trait
- Use `lower_into` for lowering `ty::Variance`
    @matthewjasper
    matthewjasper committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    d4fa173 View commit details
    Browse the repository at this point in the history

  3. Reverse parameter to placeholder substitution in chalk results

    @matthewjasper
    matthewjasper committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    1e6d382 View commit details
    Browse the repository at this point in the history

  4. Renumber universes when canonicalizing for Chalk 

    This is required to avoid creating large numbers of universes from each
Chalk query, while still having enough universe information for lifetime
errors.
    @matthewjasper
    matthewjasper committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    caa10dc View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2022

  1. Update chalk tests

    @matthewjasper
    matthewjasper committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    f718b51 View commit details
    Browse the repository at this point in the history

  2. Address review comment 

    canonicalize_chalk_query -> canonicalize_query_preserving_universes
    @matthewjasper
    matthewjasper committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    030c508 View commit details
    Browse the repository at this point in the history