Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dist-(arm|armv7|armhf)-linux to Ubuntu 20.04 #93837

Merged
merged 3 commits into from
Feb 13, 2022

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Feb 9, 2022

I believe this should be safe, as actual artifacts will be produced by a cross toolchain. The build ran through cleanly locally.

This came up in #93577, where the host GCC ICEd during the LLD build. (Though I wonder why we build LLD for the host at all...)

r? @Mark-Simulacrum

I believe this should be safe, as actual artifacts will be
produced by a cross toolchain. The build ran through cleanly
locally.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2022
@Mark-Simulacrum
Copy link
Member

We currently document ARMv6 Linux (kernel 3.2, glibc 2.17) as the support for arm-unknown-linux-gnueabi, which this builder produces.

I suspect that glibc 2.17 is older than even Ubuntu 18.04, but we probably should at least bump those docs alongside this PR. Since this target doesn't have a current maintainer, there's probably no one in particular to ping, though we could reach out to the Arm folks I suppose.

@matthiaskrgr matthiaskrgr added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Feb 9, 2022
@nikic
Copy link
Contributor Author

nikic commented Feb 9, 2022

@Mark-Simulacrum Isn't the used kernel and glibc version controlled by the crosstool-ng config, rather than the host operating system? I thought the host OS is only relevant for cases where we don't use a cross toolchain (like the primary x86 dist builders).

@Mark-Simulacrum
Copy link
Member

Ah, right. Yeah, that makes sense I think.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 9, 2022

📌 Commit e644fb5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2022
@Mark-Simulacrum
Copy link
Member

@bors rollup=iffy -- will need a docker cache re-population

@nikic nikic mentioned this pull request Feb 10, 2022
11 tasks
@nikic nikic changed the title Update dist-arm-linux to Ubuntu 20.04 Update dist-(arm|armv7)-linux to Ubuntu 20.04 Feb 10, 2022
@nikic
Copy link
Contributor Author

nikic commented Feb 10, 2022

In the interest of more efficient docker cache repopulation I've updated dist-armv7-linux as well. Based on a local run, that one works fine with ubuntu 20.04 as well.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Feb 10, 2022

📌 Commit 6d2aa18 has been approved by Mark-Simulacrum

@nikic nikic changed the title Update dist-(arm|armv7)-linux to Ubuntu 20.04 Update dist-(arm|armv7|armhf)-linux to Ubuntu 20.04 Feb 10, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Feb 10, 2022

📌 Commit 2c8c4f1 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Feb 13, 2022

⌛ Testing commit 2c8c4f1 with merge 1a8fa2a...

@bors
Copy link
Contributor

bors commented Feb 13, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 1a8fa2a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 13, 2022
@bors bors merged commit 1a8fa2a into rust-lang:master Feb 13, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 13, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1a8fa2a): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants