Describe VecDeque with more consistent names #93899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
It might be good to introduce the word - A double-ended queue implemented with a growable ring buffer.
+ A double-ended queue (deque) implemented with a growable ring buffer. |
m-ou-se
added
the
T-libs
ssomers
force-pushed
the
vecdeque_naming
branch
from
e375ac3 to
5cdee93
Compare
It is indeed. |
ssomers
force-pushed
the
vecdeque_naming
branch
from
5cdee93 to
5d53597
Compare
|
Oops, only now I noticed that I did find and replace the word "queue", leading to the unfortunate description "double-ended deque". Fixed. |
|
@bors r+ rollup |
|
📌 Commit 5d53597 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#93899 (Describe VecDeque with more consistent names) - rust-lang#93949 (Add basic platform support to library/{panic_}unwind for m68k) - rust-lang#93999 (suggest using raw strings when invalid escapes appear in literals) - rust-lang#94001 (llvm: migrate to new parameter-bearing uwtable attr) - rust-lang#94014 (Move transmute_undefined_repr back to nursery) Failed merges: - rust-lang#94020 (Support pretty printing of invalid constants) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public documentation of VecDeque starts describing itself as a "queue". In method descriptions, it's
neversometimes named queue again, orVecDeque(IMO a sometimes useful and often noisy notation) or "deque" or "vector". In examples,deque,v(hidden inrange_mut) orvector. Here is a subjective attempt at more consistency.