Rollup of 12 pull requests #94286
Merged
Rollup of 12 pull requests #94286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `NullOp::Box` Follow up of rust-lang#89030 and MCP rust-lang/compiler-team#460. ~1 month later nothing seems to be broken, apart from a small regression that rust-lang#89332 (1aac85bb716c09304b313d69d30d74fe7e8e1a8e) shows could be regained by remvoing the diverging path, so it shall be safe to continue and remove `NullOp::Box` completely. r? `@jonas-schievink` `@rustbot` label T-compiler
This version fixes the regressions in 0.79.0
Using the arguments often saves a layout_of call
This should reduce compile times of cg_clif
This reduces code size
Also directly use an array instead of going through a tuple. This reduces the amount of llvm ir lines for this function by almost half from 3086 to 1662.
This reduces the amount of llvm ir lines for this function by a little over half from 1662 to 781.
This effectively outlines it, significantly reducing the size of the codegen_simd_intrinsic_call llvm ir from 10419 lines to 6378 lines.
Real simd support will need an overhaul in the future anyway. For now it only complicates the code.
…edness doesn't matter This is slightly more verbose when invoking the macro.
This halves the total amount of llvm ir lines for simd related functions from 18227 to 9604.
This reduces the total amount of llvm ir lines for simd related functions from 9604 to 9467.
…times Refactor the intrinsics module for slightly better build times
y.rs can't be rustfmt'ed without making it no longer be a valid bash script.
The field is also renamed from `ident` to `name. In most cases, we don't actually need the `Span`. A new `ident` method is added to `VariantDef` and `FieldDef`, which constructs the full `Ident` using `tcx.def_ident_span()`. This method is used in the cases where we actually need an `Ident`. This makes incremental compilation properly track changes to the `Span`, without all of the invalidations caused by storing a `Span` directly via an `Ident`.
…, r=notriddle Fix rustdoc infinite redirection generation Someone came to me about a funny bug they had when clicking on any link on [this page](https://world.pages.gitlab.gnome.org/Rust/libadwaita-rs/stable/latest/docs/libadwaita/builders/index.html): it ended one page redirecting to itself indefinitely. I was able to make a minimum reproducible case to trigger this bug which I now use as a test. r? ``@notriddle``
Typo fix: Close inline-code backtick A drop in the ocean.
Fix typo. Yeah just a typo (probably some breaking changes in here be careful) :)
Miri: extend comments on downcast operation r? `@oli-obk`
Rename `region_should_not_be_omitted` to `should_print_region` to avoid double negation
…jorn3 Sync rustc_codegen_cranelift r? `@ghost` `@rustbot` label +A-codegen +A-cranelift +T-compiler
rustbot
added
T-compiler
|
@bors r+ rollup=never p=12 |
|
📌 Commit 8f53bdb has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 8f53bdb with merge 042a1c0478f4f4078f9792520556eca9b1119421... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry auto (dist-x86_64-apple no logs |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Feb 23, 2022
|
Finished benchmarking commit (532d3cd): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
PathBuftoo #94240 (Suggest calling .display() onPathBuftoo)region_should_not_be_omittedtoshould_print_region#94280 (Renameregion_should_not_be_omittedtoshould_print_region)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup