tutorial.md : correct formula in fn area() #9459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change formula (other solution could be using abs()).
|
Well, that depends on coordinate system, doesn't it? SDL uses upper left origin, for example. |
|
That's why i like the idea of specifying rectangles by using one coordinate (e.g. top-left) and the 2 dimensions width and height. |
|
Approving this since it's correct for the typical cartesian plane (...and because it's a saturday morning and bors is idle). If you feel that the example needs to be changed more substantially, send a PR of your own! |
bors
added a commit
that referenced
this pull request
Sep 28, 2013
change formula (other solution could be using abs()).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 6, 2022
Fix ICE in `needless_pass_by_value` with unsized `dyn Fn` fixes rust-lang#9459 Not really sure why a query for a type implementing `FnOnce` even works since the trait if `FnOnce<T>`, but it seems to. I would have expected it to crash like it does when passing `dyn FnOnce()` as the type. changelog: [`needless_pass_by_value`](https://rust-lang.github.io/rust-clippy/master/#needless_pass_by_value) Fix ICE in with unsized `dyn Fn` argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change formula (other solution could be using abs()).