Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest removing a semicolon after derive attributes #94633

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Suggest removing a semicolon after derive attributes #94633

merged 1 commit into from
Mar 5, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Mar 5, 2022

closes #93942

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 5, 2022
@rust-highfive
Copy link
Collaborator

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2022
@cjgillot
Copy link
Contributor

cjgillot commented Mar 5, 2022

Thanks @TaKO8Ki! Could you squash the two commits together?

@TaKO8Ki TaKO8Ki force-pushed the suggest-removing-semicolon-after-derive-attribute branch from 4b49bb7 to 47d91bc Compare March 5, 2022 16:29
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Mar 5, 2022

@cjgillot
I squashed my commits!

@cjgillot
Copy link
Contributor

cjgillot commented Mar 5, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 5, 2022

📌 Commit 47d91bc has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2022
@RalfJung RalfJung mentioned this pull request Mar 5, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2022
@bors
Auto merge of rust-lang#94648 - RalfJung:rollup-4iorcrd, r=RalfJung
c274e49 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#94630 (Update note about tier 2 docs.)
 - rust-lang#94633 (Suggest removing a semicolon after derive attributes)
 - rust-lang#94642 (Fix source code pages scroll)
 - rust-lang#94645 (do not attempt to open cgroup files under Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e887e66 into rust-lang:master Mar 5, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 5, 2022
@TaKO8Ki TaKO8Ki deleted the suggest-removing-semicolon-after-derive-attribute branch March 7, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

suggest removing ; after derive attribute in case of error
6 participants
@TaKO8Ki @rust-highfive @cjgillot @bors @compiler-errors @rustbot