Only emit pointer-like metadata for Box<T, A> when A is ZST
#94728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Mar 8, 2022
| @@ -1,4 +1,4 @@ | |||
| // check-pass | |||
| // build-pass | |||
There was a problem hiding this comment.
Turns out we need build-pass to emit the metadata to trigger these tests, oopsies.
|
Thanks, @compiler-errors! Looks good to me. I think that, eventually, we'll want to remove special casing for @bors r+ |
|
📌 Commit 307ee94 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 10, 2022
…eta, r=michaelwoerister Only emit pointer-like metadata for `Box<T, A>` when `A` is ZST Basically copy the change in rust-lang#94043, but for debuginfo. r? `@michaelwoerister` Fixes rust-lang#94725
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#93950 (Use modern formatting for format! macros) - rust-lang#94274 (Treat unstable lints as unknown) - rust-lang#94368 ([1/2] Implement macro meta-variable expressions) - rust-lang#94719 (Statically compile libstdc++ everywhere if asked) - rust-lang#94728 (Only emit pointer-like metadata for `Box<T, A>` when `A` is ZST) - rust-lang#94790 (enable portable-simd doctests in Miri) - rust-lang#94811 (Update browser-ui-test version) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically copy the change in #94043, but for debuginfo.
r? @michaelwoerister
Fixes #94725