-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Perf experiment with different cargo defaults #94851
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
39cf2b9
to
0a122f4
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 0a122f4 with merge 69f654c9aa82e79f56e16f66b3c8a17019ac7289... |
☀️ Try build successful - checks-actions |
Queued 69f654c9aa82e79f56e16f66b3c8a17019ac7289 with parent f58d51b, future comparison URL. |
Finished benchmarking commit (69f654c9aa82e79f56e16f66b3c8a17019ac7289): comparison url. Summary: This benchmark run shows 31 relevant improvements 🎉 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
I'm not sure this is even going to build on CI, or whether the results I see locally are going to show up on perf.rlo: the collector mostly benchmarks leaf crates and this changes how the dependencies are built, not the leaf crate.
Maybe it'll have an effect on bootstrap.
In any case it'll at least show whether this is the correct way to benchmark with a different cargo.
r? @ghost