Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc-json: More tests, and better jsondocck errors #94861

Merged
merged 5 commits into from
Mar 16, 2022
Merged

rustdoc-json: More tests, and better jsondocck errors #94861

merged 5 commits into from
Mar 16, 2022

Conversation

aDotInTheVoid
Copy link
Member

Helps with #81359

r? @CraftSpider

@rustbot modify labels: +A-rustdoc-json +T-rustdoc +A-testsuite

@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc labels Mar 11, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2022
@CraftSpider
Copy link
Contributor

Looks good, thank you!
@bors r+

@bors
Copy link
Contributor

bors commented Mar 14, 2022

📌 Commit 4149f47 has been approved by CraftSpider

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 15, 2022
@matthiaskrgr
Rollup merge of rust-lang#94861 - aDotInTheVoid:rdj-trait-tests, r=Cr…
918888f 
…aftSpider

rustdoc-json: More tests, and better jsondocck errors

Helps with rust-lang#81359

r? `@CraftSpider`

`@rustbot` modify labels: +A-rustdoc-json +T-rustdoc +A-testsuite
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 15, 2022
Closed
@bors
Copy link
Contributor

bors commented Mar 15, 2022

⌛ Testing commit 4149f47 with merge 81bddea0dfe8eaa33cb55eed64f4583a54cb51c5...

@bors
Copy link
Contributor

bors commented Mar 15, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aDotInTheVoid
Copy link
Member Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2022
@aDotInTheVoid
Copy link
Member Author

Rebased to master, and fixed tests, needs reaproval

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 15, 2022
@CraftSpider
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 15, 2022

📌 Commit 26829c0 has been approved by CraftSpider

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2022
@bors
Copy link
Contributor

bors commented Mar 16, 2022

⌛ Testing commit 26829c0 with merge af446e1...

@bors
Copy link
Contributor

bors commented Mar 16, 2022

☀️ Test successful - checks-actions
Approved by: CraftSpider
Pushing af446e1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 16, 2022
@bors bors merged commit af446e1 into rust-lang:master Mar 16, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 16, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (af446e1): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@aDotInTheVoid aDotInTheVoid deleted the rdj-trait-tests branch July 14, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CraftSpider CraftSpider

Labels
A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
7 participants
@aDotInTheVoid @CraftSpider @bors @rust-log-analyzer @rust-timer @rust-highfive @rustbot