Support parsing IP addresses from a byte string #94890

marmeladema · 2022-03-12T18:37:43Z

The goal is to be able to parse addresses from a byte string without requiring to do any utf8 validation. Since internally the parser already works on byte strings, this should be possible and I personally already needed this in the past too.

I used the proposed approach from the issue by implementing TryFrom<&'a [u8]> for all 6 address types (3 ip address types and 3 socket address types). I believe implementing stable traits for stable types is insta-stable so this will probably need an FCP?

Switched to an unstable inherent method approach called parse_ascii as requested.

cc @jyn514

rust-highfive · 2022-03-12T18:37:46Z

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

nagisa · 2022-03-12T21:46:08Z

I don't believe TryFrom is a correct approach, given the gratuitous amount of confusion about what the referenced issue was about. I'd say an inherent function along the lines of IpAddr::parse_ascii would likely be unambiguous in what it means.

marmeladema · 2022-03-13T00:16:19Z

Alright, I think I agree it's clearer to have an inherent method for this. I have updated the code and left the tracking issue empty for now in the unstable directives. This PR now only adds unstable methods so it might not require an FCP at this stage right?
I'll create the tracking issue once the code here is approved 👍

marmeladema · 2022-04-07T22:01:19Z

@yaahc @nagisa any interest in this or should the associated issue be rejected and this PR closed?

yaahc · 2022-04-08T00:28:19Z

I haven't had a chance to review this yet but based on the description I'm assuming there will be interest in these APIs. Also, please forgive me if I'm reading too much into your statement but if you're asking because you are wondering why there hasn't been a review that's just because t-libs-api review can take quite a while¹, but one of us will get to this review as soon as we're able.

My PR which I pushed in october which only just got approved today: https://github.com/rust-lang/rust/pull/90066 ↩

bors · 2022-04-20T21:31:13Z

☔ The latest upstream changes (presumably #96253) made this pull request unmergeable. Please resolve the merge conflicts.

yaahc · 2022-04-29T22:50:56Z

I'm reassigning this PR because I'm taking a break from the review rotation for a little while. Thank you for your patience.

r? rust-lang/libs-api

joshtriplett · 2022-08-26T10:17:03Z

This seems reasonable to me.

r=me after you fix the merge conflicts and add a tracking issue.

@bors delegate+

bors · 2022-08-26T10:17:05Z

✌️ @marmeladema can now approve this pull request

library/std/src/net/parser.rs

marmeladema · 2022-08-26T13:07:59Z

@bors r=joshtriplett

bors · 2022-08-26T13:08:01Z

📌 Commit 8bb4b5f has been approved by joshtriplett

It is now in the queue for this repository.

… r=joshtriplett Support parsing IP addresses from a byte string Fixes rust-lang#94821 The goal is to be able to parse addresses from a byte string without requiring to do any utf8 validation. Since internally the parser already works on byte strings, this should be possible and I personally already needed this in the past too. ~~I used the proposed approach from the issue by implementing `TryFrom<&'a [u8]>` for all 6 address types (3 ip address types and 3 socket address types). I believe implementing stable traits for stable types is insta-stable so this will probably need an FCP?~~ Switched to an unstable inherent method approach called `parse_ascii` as requested. cc `@jyn514`

… r=joshtriplett Support parsing IP addresses from a byte string Fixes rust-lang#94821 The goal is to be able to parse addresses from a byte string without requiring to do any utf8 validation. Since internally the parser already works on byte strings, this should be possible and I personally already needed this in the past too. ~~I used the proposed approach from the issue by implementing `TryFrom<&'a [u8]>` for all 6 address types (3 ip address types and 3 socket address types). I believe implementing stable traits for stable types is insta-stable so this will probably need an FCP?~~ Switched to an unstable inherent method approach called `parse_ascii` as requested. cc ``@jyn514``

… r=joshtriplett Support parsing IP addresses from a byte string Fixes rust-lang#94821 The goal is to be able to parse addresses from a byte string without requiring to do any utf8 validation. Since internally the parser already works on byte strings, this should be possible and I personally already needed this in the past too. ~~I used the proposed approach from the issue by implementing `TryFrom<&'a [u8]>` for all 6 address types (3 ip address types and 3 socket address types). I believe implementing stable traits for stable types is insta-stable so this will probably need an FCP?~~ Switched to an unstable inherent method approach called `parse_ascii` as requested. cc `@jyn514`

… r=joshtriplett Support parsing IP addresses from a byte string Fixes rust-lang#94821 The goal is to be able to parse addresses from a byte string without requiring to do any utf8 validation. Since internally the parser already works on byte strings, this should be possible and I personally already needed this in the past too. ~~I used the proposed approach from the issue by implementing `TryFrom<&'a [u8]>` for all 6 address types (3 ip address types and 3 socket address types). I believe implementing stable traits for stable types is insta-stable so this will probably need an FCP?~~ Switched to an unstable inherent method approach called `parse_ascii` as requested. cc ``@jyn514``

… r=joshtriplett Support parsing IP addresses from a byte string Fixes rust-lang#94821 The goal is to be able to parse addresses from a byte string without requiring to do any utf8 validation. Since internally the parser already works on byte strings, this should be possible and I personally already needed this in the past too. ~~I used the proposed approach from the issue by implementing `TryFrom<&'a [u8]>` for all 6 address types (3 ip address types and 3 socket address types). I believe implementing stable traits for stable types is insta-stable so this will probably need an FCP?~~ Switched to an unstable inherent method approach called `parse_ascii` as requested. cc ```@jyn514```

… r=joshtriplett Support parsing IP addresses from a byte string Fixes rust-lang#94821 The goal is to be able to parse addresses from a byte string without requiring to do any utf8 validation. Since internally the parser already works on byte strings, this should be possible and I personally already needed this in the past too. ~~I used the proposed approach from the issue by implementing `TryFrom<&'a [u8]>` for all 6 address types (3 ip address types and 3 socket address types). I believe implementing stable traits for stable types is insta-stable so this will probably need an FCP?~~ Switched to an unstable inherent method approach called `parse_ascii` as requested. cc ````@jyn514````

… r=joshtriplett Support parsing IP addresses from a byte string Fixes rust-lang#94821 The goal is to be able to parse addresses from a byte string without requiring to do any utf8 validation. Since internally the parser already works on byte strings, this should be possible and I personally already needed this in the past too. ~~I used the proposed approach from the issue by implementing `TryFrom<&'a [u8]>` for all 6 address types (3 ip address types and 3 socket address types). I believe implementing stable traits for stable types is insta-stable so this will probably need an FCP?~~ Switched to an unstable inherent method approach called `parse_ascii` as requested. cc `````@jyn514`````

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#94890 (Support parsing IP addresses from a byte string) - rust-lang#96334 (socket `set_mark` addition.) - rust-lang#99027 (Replace `Body::basic_blocks()` with field access) - rust-lang#100437 (Improve const mismatch `FulfillmentError`) - rust-lang#100843 (Migrate part of rustc_infer to session diagnostic) - rust-lang#100897 (extra sanity check against consts pointing to mutable memory) - rust-lang#100959 (translations: rename warn_ to warning) - rust-lang#101111 (Use the declaration's SourceInfo for FnEntry retags, not the outermost) - rust-lang#101116 ([rustdoc] Remove Attrs type alias) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned yaahc Mar 12, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2022

marmeladema force-pushed the ip-addr-try-from-bytes branch from c4bffc0 to 85308fd Compare March 13, 2022 00:12

marmeladema force-pushed the ip-addr-try-from-bytes branch from 85308fd to 33b6772 Compare March 13, 2022 08:53

yaahc added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 18, 2022

rust-highfive assigned m-ou-se and unassigned yaahc Apr 29, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2022

the8472 reviewed Aug 26, 2022

View reviewed changes

library/std/src/net/parser.rs Outdated Show resolved Hide resolved

marmeladema force-pushed the ip-addr-try-from-bytes branch from 33b6772 to 129cc05 Compare August 26, 2022 11:22

marmeladema mentioned this pull request Aug 26, 2022

Tracking Issue for addr_parse_ascii feature #101035

Open

3 tasks

Support parsing IP addresses from a byte string

8bb4b5f

marmeladema force-pushed the ip-addr-try-from-bytes branch from 129cc05 to 8bb4b5f Compare August 26, 2022 12:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2022

Dylan-DPC mentioned this pull request Aug 26, 2022

Rollup of 9 pull requests #101052

Closed

compiler-errors mentioned this pull request Aug 27, 2022

Rollup of 12 pull requests #101073

Closed

Dylan-DPC mentioned this pull request Aug 28, 2022

Rollup of 8 pull requests #101124

Closed

Dylan-DPC mentioned this pull request Aug 28, 2022

Rollup of 9 pull requests #101128

Closed

matthiaskrgr mentioned this pull request Aug 28, 2022

Rollup of 12 pull requests #101132

Closed

matthiaskrgr mentioned this pull request Aug 28, 2022

Rollup of 11 pull requests #101136

Closed

matthiaskrgr mentioned this pull request Aug 28, 2022

Rollup of 10 pull requests #101137

Closed

matthiaskrgr mentioned this pull request Aug 29, 2022

Rollup of 9 pull requests #101143

Merged

bors merged commit 52016a1 into rust-lang:master Aug 29, 2022

rustbot added this to the 1.65.0 milestone Aug 29, 2022

marmeladema deleted the ip-addr-try-from-bytes branch August 29, 2022 08:11

tgross35 mentioned this pull request Oct 26, 2023

ACP: Add FromByteStr trait with blanket impl FromStr rust-lang/libs-team#287

Open

Turbo87 mentioned this pull request Oct 27, 2023

core::net: Rename parse_ascii() fns to from_bytes() #117274

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support parsing IP addresses from a byte string #94890

Support parsing IP addresses from a byte string #94890

marmeladema commented Mar 12, 2022 •

edited

Loading

rust-highfive commented Mar 12, 2022

nagisa commented Mar 12, 2022

marmeladema commented Mar 13, 2022

marmeladema commented Apr 7, 2022

yaahc commented Apr 8, 2022

bors commented Apr 20, 2022

yaahc commented Apr 29, 2022

joshtriplett commented Aug 26, 2022 •

edited

Loading

bors commented Aug 26, 2022

marmeladema commented Aug 26, 2022

bors commented Aug 26, 2022

Support parsing IP addresses from a byte string #94890

Support parsing IP addresses from a byte string #94890

Conversation

marmeladema commented Mar 12, 2022 • edited Loading

rust-highfive commented Mar 12, 2022

nagisa commented Mar 12, 2022

marmeladema commented Mar 13, 2022

marmeladema commented Apr 7, 2022

yaahc commented Apr 8, 2022

Footnotes

bors commented Apr 20, 2022

yaahc commented Apr 29, 2022

joshtriplett commented Aug 26, 2022 • edited Loading

bors commented Aug 26, 2022

marmeladema commented Aug 26, 2022

bors commented Aug 26, 2022

marmeladema commented Mar 12, 2022 •

edited

Loading

joshtriplett commented Aug 26, 2022 •

edited

Loading