Fix cmake build. #95050
Merged
Fix cmake build. #95050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=101 Seems at least harmless, and hopefully fixes things. |
|
📌 Commit 8322cdb has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
@bors treeclosed- |
|
Finished benchmarking commit (58f1179): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Mark-Simulacrum
added
beta-nominated
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2022
[beta] backports + bootstrap bump Add pending backports: * Revert accidental stabilization rust-lang#94805 * Do not recover from Ty? in macro parsing rust-lang#94593 * Fix cmake build. rust-lang#95050 And updates the bootstrap compiler to 1.59.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the cmake build. For some reason, it has recently started failing with a permission denied trying to overwrite
/tmp/build.log. This file exists from thebuild-toolchains.shstep, which is owned by the rustbuild user. I think there is some behavior where a sticky/tmpdirectory doesn't allow overwriting files owned by other users even when running as root. I do not know why this has suddenly started, and I can't reproduce locally with my own docker setup. However, this fix seems to work on CI.