Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Stabilize feature try_reserve_2 #95392

Merged
merged 1 commit into from
Jun 17, 2022
Merged

std: Stabilize feature try_reserve_2 #95392

merged 1 commit into from
Jun 17, 2022

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Mar 28, 2022

This PR intends to stabilize feature try_reserve_2, closes #91789

This PR will also replace the previous PR: #95139

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2022
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Mar 28, 2022

@rustbot modify labels: +T-libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 28, 2022
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Mar 28, 2022

r? @dtolnay

@rust-highfive rust-highfive assigned dtolnay and unassigned kennytm Mar 28, 2022
@Xuanwo Xuanwo force-pushed the stablize_try_reserve_2 branch from 254d06c to 5b68504 Compare March 28, 2022 02:02
This was referenced Mar 28, 2022
Closed
Closed
dtolnay
dtolnay requested changes Mar 28, 2022
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the stabilization of new APIs in a different PR than the new capacity-related guarantees. They will need two different libs-api FCP.

@dtolnay dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2022
@Xuanwo Xuanwo force-pushed the stablize_try_reserve_2 branch from 5b68504 to 8d71a8d Compare March 28, 2022 02:24
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Mar 28, 2022

Please do the stabilization of new APIs in a different PR than the new capacity-related guarantees. They will need two different libs-api FCP.

Updated.

@Xuanwo Xuanwo mentioned this pull request Mar 28, 2022
Closed
@Xuanwo Xuanwo requested a review from dtolnay March 28, 2022 02:28
@dtolnay
Copy link
Member

dtolnay commented Mar 28, 2022

This is blocked on the FCP in #91789 (comment).

@rustbot label -S-waiting-on-author +S-blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2022
@dtolnay dtolnay removed their request for review April 20, 2022 02:53
@Xuanwo Xuanwo force-pushed the stablize_try_reserve_2 branch from 8d71a8d to 5d4b203 Compare June 16, 2022 01:29
@Xuanwo
std: Stabilize feature try_reserve_2
324286f 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo force-pushed the stablize_try_reserve_2 branch from 5d4b203 to 324286f Compare June 16, 2022 01:30
@dtolnay
Copy link
Member

dtolnay commented Jun 17, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jun 17, 2022

📌 Commit 324286f has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jun 17, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 17, 2022
@bors
Auto merge of rust-lang#98193 - Dylan-DPC:rollup-5gihjij, r=Dylan-DPC
949a64a 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95392 (std: Stabilize feature try_reserve_2 )
 - rust-lang#97798 (Hide irrelevant lines in suggestions to allow for suggestions that are far from each other to be shown)
 - rust-lang#97844 (Windows: No panic if function not (yet) available)
 - rust-lang#98013 (Subtype FRU fields first in `type_changing_struct_update`)
 - rust-lang#98191 (Remove the rest of unnecessary `to_string`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b516806 into rust-lang:master Jun 17, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 17, 2022
@Xuanwo Xuanwo deleted the stablize_try_reserve_2 branch June 18, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for try_reserve method on more containers
6 participants
@Xuanwo @rust-highfive @dtolnay @bors @kennytm @rustbot