Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellchecking compiler literals #95499

Closed
wants to merge 3 commits into from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Mar 30, 2022

This PR cleans up the spelling mistakes in the compiler literals.

This PR cleans up the spelling mistakes in the compiler literals.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 30, 2022
@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2022
@@ -332,7 +332,7 @@ impl UnsafeCode {
self.report_unsafe(cx, span, |lint| {
lint.build(msg)
.note(
"the linker's behavior with multiple libraries exporting duplicate symbol \
"the linker behavior with multiple libraries exporting duplicate symbol \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels incorrect grammatically, but i'm not an expert. Spellchecker didn't like it either. Not sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it still makes sense grammatically though in this case

@compiler-errors
Copy link
Member

Re: discussion on #95497, let's close this one per the spellcheck PR policy decided by the compiler team, since it didn't go through an intensive review yet.

@nyurik nyurik deleted the spelling-literals branch March 31, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants