Mention std::env::var in env!
#95646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
jyn514
suggested changes
Apr 4, 2022
This comment has been minimized.
This comment has been minimized.
mgeisler
force-pushed
the
mention-std-env-var
branch
from
79d2f3b
to
8d9b7b4
Compare
When searching for how to read an environment variable, I first encountered the `env!` macro. It would have been useful to me if the documentation had included a link to `std::env::var`, which is what I was actually looking for.
mgeisler
force-pushed
the
mention-std-env-var
branch
from
8d9b7b4
to
4f08d75
Compare
|
@bors r+ rollup |
|
📌 Commit 4f08d75 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#95352 ([bootstrap] Print the full relative path to failed tests) - rust-lang#95646 (Mention `std::env::var` in `env!`) - rust-lang#95708 (Update documentation for `trim*` and `is_whitespace` to include newlines) - rust-lang#95714 (Add test for issue rust-lang#83474) - rust-lang#95725 (Message: Chunks cannot have a size of zero.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for how to read an environment variable, I first encountered the
env!macro. It would have been useful to me if the documentation had included a link tostd::env::var, which is what I was actually looking for.