New mir-opt deref_separator #95649
Merged
New mir-opt deref_separator #95649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @oli-obk |
This comment has been minimized.
This comment has been minimized.
oli-obk
requested changes
Apr 4, 2022
src/test/mir-opt/inline/issue_58867_inline_as_ref_as_mut.a.Inline.after.mir
Outdated
Show resolved
Hide resolved
oli-obk
reviewed
Apr 4, 2022
| // and copying derefed values which we need to create new statement | ||
| let temp_place = | ||
| Place::from(temp).project_deeper(&place.projection[idx..], tcx); | ||
| patch.add_assign( |
There was a problem hiding this comment.
This add call is now not necessary anymore, as the exact same statement is created via mutation below
There was a problem hiding this comment.
What you can add though is a storagdead statement for the temp. Maybe that'll eliminate the extra cleanup block that showed up in a bunch of tests
There was a problem hiding this comment.
mir dump looks clean now 😸
There was a problem hiding this comment.
There are still a bunch of new cleanup blocks showing up. Let's see if a storagedead resolves those.
There was a problem hiding this comment.
I thought storagedead would resolve all of those 🤔
There was a problem hiding this comment.
Sorry, misread the code. Yea, not sure what is going on, i'll investigate
There was a problem hiding this comment.
Ah, it's just MirPatch doing that eagerly even if unneeded.
This comment has been minimized.
This comment has been minimized.
ouz-a
commented
Apr 4, 2022
oli-obk
reviewed
Apr 5, 2022
|
@bors r+ |
|
📌 Commit 1cf6d69 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 6, 2022
New mir-opt deref_separator This adds a new mir-opt that split certain derefs into this form: `let x = (*a.b).c;` to => `tmp = a.b; let x = (*tmp).c;` Huge thanks to `@oli-obk` for his patient mentoring.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#95342 (Ignore "format the world" commit in git blame) - rust-lang#95353 ([bootstrap] Give a hard error when filtering tests for a file that does not exist) - rust-lang#95649 (New mir-opt deref_separator) - rust-lang#95721 (Fix typo in bootstrap/setup.rs) - rust-lang#95730 (Rename RWLock to RwLock in std::sys.) - rust-lang#95731 (Check that all hidden types are the same and then deduplicate them.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 9, 2022
Allow multiple derefs to be splitted in deref_separator Previously in rust-lang#95649 only a single deref within projection was supported and multiple derefs caused a bunch of issues, this PR fixes those issues. `@oli-obk` helped a ton again ❤️
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 10, 2022
Allow multiple derefs to be splitted in deref_separator Previously in rust-lang#95649 only a single deref within projection was supported and multiple derefs caused a bunch of issues, this PR fixes those issues. ``@oli-obk`` helped a ton again ❤️
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 10, 2022
Allow multiple derefs to be splitted in deref_separator Previously in rust-lang#95649 only a single deref within projection was supported and multiple derefs caused a bunch of issues, this PR fixes those issues. ```@oli-obk``` helped a ton again ❤️
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2022
Make derefer work everwhere Follow up work on previous PR's rust-lang#95649 and rust-lang#95857. r? rust-lang/mir-opt _Co-Authored-By: `@oli-obk_`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new mir-opt that split certain derefs into this form:
let x = (*a.b).c;to =>tmp = a.b; let x = (*tmp).c;Huge thanks to @oli-obk for his patient mentoring.