fix: Vec leak when capacity is 0 #95699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 83f659b has been approved by |
bors
added
S-waiting-on-bors
dtolnay
added
the
T-libs
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#95659 (Rely on #[link] attribute for unwind on Fuchsia.) - rust-lang#95684 (rustdoc: Fix item info display overflow) - rust-lang#95693 (interp: pass TyCtxt to Machine methods that do not take InterpCx) - rust-lang#95699 (fix: Vec leak when capacity is 0) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
RawVec::with_capacity_inis called with capacity 0, an allocation of size 0 is allocated.However,
<RawVec as Drop>::dropdoesn't deallocate, since it only checks if capacity was 0. Fixed by not allocating when capacity is 0.