Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unused constant warning on some Windows targets #95802

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 8, 2022

When none of those cfg_if! apply (and on Miri), the constant remains unused.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 8, 2022

📌 Commit 9c97753 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 9, 2022
fix unused constant warning on some Windows targets

When none of those `cfg_if!` apply (and on Miri), the constant remains unused.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#95308 (Reduce the amount of unstable features used in libproc_macro)
 - rust-lang#95676 (Update RLS)
 - rust-lang#95769 (Hide cross-crate `#[doc(hidden)]` associated items in trait impls)
 - rust-lang#95785 (interpret: err instead of ICE on size mismatches in to_bits_or_ptr_internal)
 - rust-lang#95802 (fix unused constant warning on some Windows targets)
 - rust-lang#95810 (Use `format-args-capture` and remove unnecessary nested blocks)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit af895b0 into rust-lang:master Apr 9, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 9, 2022
@RalfJung RalfJung deleted the unused-win branch April 11, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants