Rollup of 7 pull requests #95931
Merged
Rollup of 7 pull requests #95931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table rows were obtained via the script embedded in the page.
`rustc +1.49.0 -Vv` and `rustc +1.50.0 -Vv` do not print out an `LLVM version` line, which prevents the script from detecting them.
Running `./x.py build -h -v` shows a list of available build targets, but the short alias `./x.py b -h -v` does not. Fix so that the aliases behave the same as their spelled out counterparts.
…r=Mark-Simulacrum Update binary_search example to instead redirect to partition_point Inspired by discussion in the tracking issue for `Result::into_ok_or_err`: rust-lang#82223 (comment) People are surprised by us not providing a `Result<T, T> -> T` conversion, and the main culprit for this confusion seems to be the `binary_search` API. We should instead redirect people to the equivalent API that implicitly does that `Result<T, T> -> T` conversion internally which should obviate the need for the `into_ok_or_err` function and give us time to work towards a more general solution that applies to all enums rather than just `Result` such as making or_patterns usable for situations like this via postfix `match`. I choose to duplicate the example rather than simply moving it from `binary_search` to partition point because most of the confusion seems to arise when people are looking at `binary_search`. It makes sense to me to have the example presented immediately rather than requiring people to click through to even realize there is an example. If I had to put it in only one place I'd leave it in `binary_search` and remove it from `partition_point` but it seems pretty obviously relevant to `partition_point` so I figured the best option would be to duplicate it.
…o-1.60, r=pietroalbini Update linker-plugin-lto.md to 1.60 I remembered this table when I was looking into what version of LLVM 1.60.0 was using 🙂
…an-DPC Note that CI tests Windows 10 Currently being [discussed on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/Windows.207). r? `````@joshtriplett`````
…imulacrum bootstrap: show available paths help text for aliased subcommands Running `./x.py build -h -v` shows a list of available build targets, but the short alias `./x.py b -h -v` does not. Fix so that the aliases behave the same as their spelled out counterparts.
Add a note for unsatisfied `~const Drop` bounds r? ``@oli-obk``
address fixme for diagnostic variable name quick rename
thin_box test: import from std, not alloc Importing from `alloc` makes [Miri fail](https://github.com/rust-lang/miri-test-libstd/runs/5964922742?check_suite_focus=true), probably due to the hack that we used to resolve rust-lang/miri-test-libstd#4. There might be better ways around this, but for now this is the easiest thing to do -- no other alloc integration test is importing from `alloc::`.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=7 |
|
📌 Commit 5b8e2ea has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors r+ rollup=never p=7 |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 5b8e2ea has been approved by |
|
☀️ Test successful - checks-actions |
This was referenced Apr 11, 2022
Merged
|
Finished benchmarking commit (43998d5): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
|
Seems likely to be noise -- we've not yet established a complete noise level for ctfe-stress-5 I'd guess since it was relatively recently added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
~const Dropbounds #95876 (Add a note for unsatisfied~const Dropbounds)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup