-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement core::ptr::Unique
on top of NonNull
#96010
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @thomcc (rust-highfive has picked a reviewer for you, use r? to override) |
This comment was marked as resolved.
This comment was marked as resolved.
core::ptr::Unique
on top of NonNull
core::ptr::Unique
on top of NonNull
You probably need to change the code generation by adding one additional rust/compiler/rustc_codegen_ssa/src/mir/place.rs Lines 450 to 454 in f38c5c8
rust/compiler/rustc_codegen_ssa/src/mir/place.rs Lines 465 to 469 in f38c5c8
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks for the tip |
This comment was marked as resolved.
This comment was marked as resolved.
core::ptr::Unique
on top of NonNull
core::ptr::Unique
on top of NonNull
Hmm, yeah, never really did understand what the deal with Unique was, so I'm gonna to punt this to someone else. Naïvely, it looks fine. r? rust-lang/libs |
@bors r+ |
📌 Commit a22a9a9 has been approved by |
… r=m-ou-se Implement `core::ptr::Unique` on top of `NonNull` Removes the use `rustc_layout_scalar_valid_range_start` and some `unsafe` blocks.
Can we run MSVC CI on this PR to test CDB without waiting for rollup? |
It's possible, but there's no bot command or something to do that. You'd have to temporarily modify |
core::ptr::Unique
on top of NonNull
core::ptr::Unique
on top of NonNull
This comment was marked as resolved.
This comment was marked as resolved.
core::ptr::Unique
on top of NonNull
core::ptr::Unique
on top of NonNull
MSVC tests have finally passed, reverted PR CI changes |
You can squash commits a little, instead of having unrelated ones in history. |
Done |
@rustbot label -S-waiting-on-bors +S-waiting-on-review |
@bors r=m-ou-se,tmiasko rollup=never |
📌 Commit 7ba0292 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ac8b118): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
@eduardosm or @m-ou-se , do either of you have time to look into the cause of this? I'm tempted to suggest we revert it, unless someone can present an argument for why we need it. |
nominating for attention from T-libs, in the hopes that someone can address my concerns above. |
Removes the use
rustc_layout_scalar_valid_range_start
and someunsafe
blocks.