Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --extern-location and all associated code #96086

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

jsgf
Copy link
Contributor

@jsgf jsgf commented Apr 15, 2022

--extern-location was an experiment to investigate the best way to
generate useful diagnostics for unused dependency warnings by enabling a
build system to identify the corresponding build config.

While I did successfully use this, I've since been convinced the
alternative --json unused-externs mechanism is the way to go, and
there's no point in having two mechanisms with basically the same
functionality.

This effectively reverts #72603

`--extern-location` was an experiment to investigate the best way to
generate useful diagnostics for unused dependency warnings by enabling a
build system to identify the corresponding build config.

While I did successfully use this, I've since been convinced the
alternative `--json unused-externs` mechanism is the way to go, and
there's no point in having two mechanisms with basically the same
functionality.

This effectively reverts rust-lang#72603
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 15, 2022
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2022
@jsgf
Copy link
Contributor Author

jsgf commented Apr 15, 2022

I posted a to irlo in case someone is actually using this functionality, but AFAIK I'm the only one: https://internals.rust-lang.org/t/anyone-using-extern-location/16480

Also cc @petrochenkov @nikomatsakis as reviewers on #72603.

@davidtwco
Copy link
Member

Do we want to wait a little longer for anyone to tell us they are using this? r=me otherwise

@jsgf
Copy link
Contributor Author

jsgf commented Apr 19, 2022

I think we're good to go. We can always revert this PR if someone really needs it.

@dtolnay
Copy link
Member

dtolnay commented Apr 19, 2022

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Apr 19, 2022

📌 Commit 1be1157 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 19, 2022
…dtwco

Remove `--extern-location` and all associated code

`--extern-location` was an experiment to investigate the best way to
generate useful diagnostics for unused dependency warnings by enabling a
build system to identify the corresponding build config.

While I did successfully use this, I've since been convinced the
alternative `--json unused-externs` mechanism is the way to go, and
there's no point in having two mechanisms with basically the same
functionality.

This effectively reverts rust-lang#72603
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 19, 2022
…dtwco

Remove `--extern-location` and all associated code

`--extern-location` was an experiment to investigate the best way to
generate useful diagnostics for unused dependency warnings by enabling a
build system to identify the corresponding build config.

While I did successfully use this, I've since been convinced the
alternative `--json unused-externs` mechanism is the way to go, and
there's no point in having two mechanisms with basically the same
functionality.

This effectively reverts rust-lang#72603
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#94493 (Improved diagnostic on failure to meet send bound on future in a foreign crate)
 - rust-lang#95809 (Fix typo in bootstrap.py)
 - rust-lang#96086 (Remove `--extern-location` and all associated code)
 - rust-lang#96089 (`alloc`: make `vec!` unavailable under `no_global_oom_handling`)
 - rust-lang#96122 (Fix an invalid error for a suggestion to add a slice in pattern-matching)
 - rust-lang#96142 (Stop using CRATE_DEF_INDEX outside of metadata encoding.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5f10d13 into rust-lang:master Apr 19, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 19, 2022
facebook-github-bot pushed a commit to facebook/buck that referenced this pull request Apr 20, 2022
Summary:
`--extern-location` was an experimental option in rustc to pass tool
diagnostic information through rustc. It was used to pass location information
for unused dependencies from Buck via rustc for consumption by rustfixdeps.

This was removed in upstream rust in
rust-lang/rust#96086 so remove support for it here.

Reviewed By: cjhopman

fbshipit-source-id: 3509c3b2680a3a86fc782839f2a12312674f9d52
@jsgf jsgf deleted the remove-extern-location branch May 16, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants