Followups for method call error change #96155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #96663) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
approved these changes
May 4, 2022
jackh726
force-pushed
the
param-heuristics-followup
branch
from
6e86c78
to
e237e78
Compare
|
It seems you have to rebase again 😅 |
|
Yeah. I had to step away from my computer before I was actually able to rebase (just made the review changes). |
jackh726
force-pushed
the
param-heuristics-followup
branch
from
e237e78
to
abde236
Compare
jackh726
force-pushed
the
param-heuristics-followup
branch
from
abde236
to
7d8e10d
Compare
|
@bors r=estebank |
|
📌 Commit 7d8e10d has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 7, 2022
… r=estebank Followups for method call error change Each commit is self-contained. Fixes most of the followup reviews from that PR. r? `@estebank`
|
⌛ Testing commit 7d8e10d with merge baf9b0e83903681ab8324b1286ef1cd30217c5aa... |
Merged
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (030c886): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit is self-contained. Fixes most of the followup reviews from that PR.
r? @estebank