Drop support for legacy PM with LLVM 15 #96215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
bjorn3
reviewed
Apr 19, 2022
luqmana
reviewed
Apr 19, 2022
luqmana
reviewed
Apr 20, 2022
luqmana
added a commit
to luqmana/rust
that referenced
this pull request
Apr 20, 2022
The linked issue has an accurate description of the situation, drop the inaccurate comment.
nikic
force-pushed
the
legacy-pm-removal
branch
from
03fca98 to
6dc0bcc
Compare
|
r? @nagisa (maybe?) |
|
@bors r+ Seems clunky, but I think we can live with the clunk for the time being. |
|
📌 Commit 6dc0bcc has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#95395 (Better error message for `_` in function signature in `impl Trait for Ty`) - rust-lang#96090 (Implement MIR opt unit tests) - rust-lang#96107 ([test] Add test cases for untested functions for VecDeque) - rust-lang#96212 (Use revisions instead of nll compare mode for `/regions/` ui tests) - rust-lang#96215 (Drop support for legacy PM with LLVM 15) - rust-lang#96366 (bootstrap: Remove dead code in rustdoc shim) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM 15 already removes some of the legacy PM APIs we're using. This patch forces use of NewPM with LLVM 15 (with
-Z new-llvm-pass-manager=nothrowing a warning) and stubs out various FFI methods with a report_fatal_error on LLVM 15.For LLVMPassManagerBuilderPopulateLTOPassManager() I went with adding our own wrapper, as the alternative would be to muck about with weak symbols, which seems to be non-trivial as far as cross-platform support is concerned (std has
weak!for this purpose, but only as an internal utility.)Fixes #96072.
Fixes #96362.