-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix locations for intrinsics impls and change to links #96228
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @thomcc (rust-highfive has picked a reviewer for you, use r? to override) |
I don't know what these paths are. I'll reroll for you but feel free to request a specific reviewer who knows where these are. r? rust-lang/libs |
@thomcc / @joshtriplett They are just from the root of this repo. Should I change them to be a link to Github, like the one referring to miri (line 12)? |
A link would be better, as it could also detect breakage using rustdoc's link checker. |
Okay. This is fine. Sorry for the trouble (both to you and to @joshtriplett). I thought I was missing context for this change, but I wasn't. That said, I think the link should hold up slightly better. @bors r+ |
📌 Commit 4879875 has been approved by |
@thomcc |
Rollup of 5 pull requests Successful merges: - rust-lang#90630 (Create real parser for search queries) - rust-lang#96193 ([fuchsia] Add implementation for `current_exe`) - rust-lang#96196 (Remove assertion that all paths in `ShouldRun` exist) - rust-lang#96228 (Fix locations for intrinsics impls and change to links) - rust-lang#96236 (Add an explicit `Span` field to `OutlivesConstraint`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
These still referred to
rustc_mir
.