Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky rustdoc-ui test because it did not replace time result #96668

Merged
merged 1 commit into from
May 4, 2022

Conversation

GuillaumeGomez
Copy link
Member

As mentioned in #93715: a test is flaky because I forgot to replace the time value.

This PR fixes it.

r? @petrochenkov

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 3, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2022
@petrochenkov
Copy link
Contributor

block-doc-comment.stdout still mentions the time explicitly, so the replacement didn't work.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2022
@GuillaumeGomez
Copy link
Member Author

Indeed...

@GuillaumeGomez
Copy link
Member Author

Fixed for good this time.

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 3, 2022

📌 Commit 56c2769 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 3, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 3, 2022
…-test, r=petrochenkov

Fix flaky rustdoc-ui test because it did not replace time result

As mentioned in rust-lang#93715: a test is flaky because I forgot to replace the time value.

This PR fixes it.

r? `@petrochenkov`
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96597 (openbsd: unbreak build on native platform)
 - rust-lang#96662 (Fix typo in lint levels doc)
 - rust-lang#96668 (Fix flaky rustdoc-ui test because it did not replace time result)
 - rust-lang#96679 (Quick fix for rust-lang#96223.)
 - rust-lang#96684 (Update `ProjectionElem::Downcast` documentation)
 - rust-lang#96686 (Add some TAIT-related tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b255bf9 into rust-lang:master May 4, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 4, 2022
@GuillaumeGomez GuillaumeGomez deleted the fix-rustdoc-ui-flaky-test branch May 4, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants