Fix flaky rustdoc-ui test because it did not replace time result #96668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
|
petrochenkov
added
S-waiting-on-author
|
Indeed... |
GuillaumeGomez
force-pushed
the
fix-rustdoc-ui-flaky-test
branch
from
c70cdeb
to
56c2769
Compare
|
Fixed for good this time. |
|
@bors r+ rollup |
|
📌 Commit 56c2769 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 3, 2022
…-test, r=petrochenkov Fix flaky rustdoc-ui test because it did not replace time result As mentioned in rust-lang#93715: a test is flaky because I forgot to replace the time value. This PR fixes it. r? `@petrochenkov`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#96597 (openbsd: unbreak build on native platform) - rust-lang#96662 (Fix typo in lint levels doc) - rust-lang#96668 (Fix flaky rustdoc-ui test because it did not replace time result) - rust-lang#96679 (Quick fix for rust-lang#96223.) - rust-lang#96684 (Update `ProjectionElem::Downcast` documentation) - rust-lang#96686 (Add some TAIT-related tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #93715: a test is flaky because I forgot to replace the time value.
This PR fixes it.
r? @petrochenkov