Check hidden types for well formedness at the definition site instead of only at the opaque type itself #96736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
oli-obk
commented
May 5, 2022
| LL | type X<T> = impl Clone; | ||
| | ^^^^^^^^^^ the trait `Clone` is not implemented for `T` | ||
| LL | t | ||
| | ^ the trait `Clone` is not implemented for `T` |
There was a problem hiding this comment.
It's slightly confusing that we're talking about T here and f also has a T, but considering the help right below, that should be explanatory enough for this PR I think.
I want to add a new type-alias-impl-trait ObligationCause that we will then use to improve this diagnostic.
davidtwco
approved these changes
May 6, 2022
… of only at the opaque type itself
oli-obk
force-pushed
the
tait_missing_wf_check
branch
from
17fe901 to
f667e95
Compare
|
@bors r=davidtwco |
|
📌 Commit f667e95 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (eead58e): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 13, 2022
…komatsakis Check that closures satisfy their where bounds fixes rust-lang#53092 fixes rust-lang#90409 based on rust-lang#96736
yvt
added a commit
to r3-os/r3
that referenced
this pull request
May 14, 2022
It seems that [rust-lang/rust#96736][1] introduced checks for these missing bounds, resulting in the following compilation error: error[E0277]: expected a `FnOnce<(Output,)>` closure, found `Mapper` --> src/r3_core/src/bind.rs:1360:5 | 1360 | move || (mapper)(inner_bound_fn()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an `FnOnce<(Output,)>` closure, found `Mapper` | note: required by a bound in `map_bind_inner` --> src/r3_core/src/bind.rs:1358:13 | 1352 | const fn map_bind_inner<InnerBoundFn, Output, Mapper, NewOutput>( | -------------- required by a bound in this ... 1358 | Mapper: FnOnce(Output) -> NewOutput + Copy + Send + 'static, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `map_bind_inner` help: consider further restricting this bound | 1349 | Mapper: Copy + Send + 'static + core::ops::FnOnce<(Output,)>, | ++++++++++++++++++++++++++++++ [1]: rust-lang/rust#96736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work towards #90409 . We'll need to look into closure and generator bodies of closures and generators nested inside the hidden type in order to fix that. In hindsight this PR is not necessary for that, but it may be a bit easier with it and we'll get better diagnostics from it on its own.