Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quadratic behaviour from -Zunpretty=hir-tree. #97223

Merged
merged 1 commit into from
May 21, 2022

Conversation

cjgillot
Copy link
Contributor

Closes #97115

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 20, 2022
@jackh726
Copy link
Member

Was this reflected in perf testing at all? If not, it might be worth thinking about adding a benchmark to that (but I don't think it's required and I don't think a test here is warranted).

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 20, 2022

📌 Commit cd90406 has been approved by jackh726

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 20, 2022
@cjgillot
Copy link
Contributor Author

Was this reflected in perf testing at all? If not, it might be worth thinking about adding a benchmark to that (but I don't think it's required and I don't think a test here is warranted).

It's a debugging option, so I don't think such a test is useful.

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request May 21, 2022
Remove quadratic behaviour from -Zunpretty=hir-tree.

Closes rust-lang#97115
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2022
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#97190 (Add implicit call to from_str via parse in documentation)
 - rust-lang#97218 (Add eslint checks)
 - rust-lang#97219 (make ptr::invalid not the same as a regular int2ptr cast)
 - rust-lang#97223 (Remove quadratic behaviour from -Zunpretty=hir-tree.)
 - rust-lang#97232 (typo)
 - rust-lang#97237 (Add some more weird-exprs)
 - rust-lang#97238 (Bump LLVM fetched from CI to fix run-make)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 54e36ef into rust-lang:master May 21, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 21, 2022
@cjgillot cjgillot deleted the linear-hir-tree branch May 22, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quadratic blowup on -Zunpretty=hir-tree injected 2021-10-19
4 participants